[TIMOB-24000] Module build should error if the apiversion in manifest… #9563
Conversation
… does not match the SDKs apiversion
|
I thought we discussed that the apiversion should be dictated by the module build for the selected SDK version. No? |
|
then |
|
I'm not sure. If we don't, then it might be a good idea to start a wiki page (or section of existing page) documenting the min sdk info. |
|
We do not have an exact record of the sdk versions that bumped the module api versions, but we should. The apiversion mismatch is a good time to alert the user to update both that and the minSDK. We could just ignore the user-supplied apiversion and stick the current one into the built manifest, but it means the minSDK has to be updated as well. We could stick a JSON file into the SDK to map from apiversion to sdk version and insert both (or tell the user what they should be)... |
| if (this.manifest.apiversion && sdkModuleAPIVersion && this.manifest.apiversion !== sdkModuleAPIVersion) { | ||
| logger.error(__('The module manifest apiversion is currently set to %s', this.manifest.apiversion)); | ||
| logger.error(__('Titanium SDK %s Android module apiversion is at %s', this.titaniumSdkVersion, sdkModuleAPIVersion)); | ||
| logger.error(__('Please update module manifest apiversion to match Titanium SDK module apiversion.')); |
There was a problem hiding this comment.
It'd be good to also alert them that they likely need to update the minSDK value too.
| if (this.manifest.apiversion && sdkModuleAPIVersion && this.manifest.apiversion !== sdkModuleAPIVersion) { | ||
| logger.error(__('The module manifest apiversion is currently set to %s', this.manifest.apiversion)); | ||
| logger.error(__('Titanium SDK %s iOS module apiversion is at %s', this.titaniumSdkVersion, sdkModuleAPIVersion)); | ||
| logger.error(__('Please update module manifest apiversion to match Titanium SDK module apiversion.')); |
There was a problem hiding this comment.
So at a bare minimum we should alert about minSDK too. Ideally we'd be able to tell them the minSDK version to use by adding some JSON file into our SDK (or maybe add to the package.json files) the mapping of apiversion -> minSDK.
If we had that data, we could potentially just inject the apiversion and minSDK for them - though I would assume we should at least alert them that we overrode the values or something.
… does not match the SDKs apiversion
JIRA: https://jira.appcelerator.org/browse/TIMOB-24000