Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-24679] Android: Remove invalid constant definitions #9565

Merged
merged 5 commits into from Nov 14, 2017

Conversation

garymathews
Copy link
Contributor

  • Remove invalid proxy constant definitions
TEST CASE
var audioPlayer = Ti.Media.createAudioPlayer();

// this will now be `undefined`
Ti.API.info('audioPlayer.STATE_BUFFERING: ' + audioPlayer.STATE_BUFFERING);

// this is the documented way of obtaining the constant
Ti.API.info('Ti.Media.AudioPlayer.STATE_BUFFERING: ' + Ti.Media.AudioPlayer.STATE_BUFFERING);

JIRA Ticket

@build
Copy link
Contributor

build commented Oct 27, 2017

Fails
🚫

Tests have failed, see below for more information.

Messages
📖

👍 Hey!, You deleted more code than you added. That's awesome!

Tests:

Classname Name Time Error
android.Titanium.Network.HTTPClient callbackTestForPOSTMethod 60.033 Error: timeout of 60000ms exceeded
android.Titanium.Network.HTTPClient callbackTestForGETMethod 60.011 Error: timeout of 60000ms exceeded
android.Titanium.XML xmlNodeListChildren 0.001 AssertionError: expected 0 to equal 1
android.Titanium.XML apiXmlNodeProperties 0 AssertionError: expected undefined to be a number
android.Titanium.XML xmlCData 0.003 TypeError: Cannot read property 'data' of undefined
android.Titanium.XML xmlNodeCount 0.002 AssertionError: expected true to equal false

Generated by 🚫 dangerJS

@ypbnv ypbnv self-requested a review October 30, 2017 09:38
Copy link
Contributor

@ypbnv ypbnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mukherjee2 mukherjee2 self-requested a review November 11, 2017 00:48
Copy link
Contributor

@mukherjee2 mukherjee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed with this environment:
Node Version: 6.11.5
NPM Version: 3.10.10
Mac OS: 10.13
Appc CLI: 7.0.0-master.6
Appc CLI NPM: 4.2.11-2
Titanium SDK version: 7.0.0 locally built on PR-9565
Appcelerator Studio vers 4.10.0
Android 7.1.2

@mukherjee2
Copy link
Contributor

@eric34 Can you please merge this one?

@eric34 eric34 merged commit 1587545 into tidev:master Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants