Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25466] iOS: Move iOS 11 guards inside method #9575

Merged
merged 9 commits into from Nov 9, 2017
Merged

[TIMOB-25466] iOS: Move iOS 11 guards inside method #9575

merged 9 commits into from Nov 9, 2017

Conversation

hansemannn
Copy link
Collaborator

@hansemannn
[TIMOB-25466] Move iOS 11 guards inside method
0e8fdb9 
# Conflicts:
#	iphone/Classes/TiUIWindowProxy.m
@hansemannn hansemannn added this to the 7.0.0 milestone Oct 31, 2017
@hansemannn hansemannn self-assigned this Oct 31, 2017
@build build added the ios label Nov 2, 2017
@build
Copy link
Contributor

build commented Nov 2, 2017 •
edited

Fails
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.

Generated by 🚫 dangerJS

@mukherjee2
Copy link
Contributor

@hansemannn I'm not able to Merge pull request. There are unit test failures, can you unblock this?

@hansemannn
Copy link
Collaborator Author

@mukherjee2 The Android unit-test hide() and show() change visible property value fails, I cannot help with that.

@mukherjee2
Copy link
Contributor

@garymathews , @jquick-axway per @hansemannn comment, an Android dev needs to merge this ticket, can one of you please merge? cc: @eric34

@hansemannn
Copy link
Collaborator Author

@mukherjee2 The Android unit-tests should be fixed or Jenkins should be retriggered. The Android team cannot force-merge, only @ingo and @sgtcoolguy.

@build build added the ios label Nov 8, 2017
@mukherjee2
Copy link
Contributor

@eric34 can you please force merge? FR passed, but unable to merge.

@build build added the ios label Nov 9, 2017
@sgtcoolguy sgtcoolguy merged commit 6571e0b into tidev:master Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewieberappc ewieberappc ewieberappc approved these changes

Assignees

@hansemannn hansemannn

Labels
bug ios
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hansemannn @build @mukherjee2 @ewieberappc @sgtcoolguy