Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25471] Android: Improve KrollProxy validation #9579

Merged
merged 6 commits into from Nov 15, 2017
Merged

[TIMOB-25471] Android: Improve KrollProxy validation #9579

merged 6 commits into from Nov 15, 2017

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Nov 1, 2017 •
edited

  • Improve KrollProxy validation for null objects
  • Prevent view from being processed when parent activity is being destroyed

JIRA Ticket

@garymathews garymathews added this to the 7.0.0 milestone Nov 1, 2017
@build build added the android label Nov 2, 2017
@build
Copy link
Contributor

build commented Nov 2, 2017 •
edited

Fails
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.
🚫

Tests have failed, see below for more information.

Tests:

Classname Name Time Error
android.Titanium.Network.HTTPClient clearCookieUnaffectedCheck 60.038 Error: timeout of 60000ms exceeded

Generated by 🚫 dangerJS

jquick-axway
jquick-axway approved these changes Nov 6, 2017
View reviewed changes
Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@build build added the android label Nov 13, 2017
@mukherjee2 mukherjee2 self-requested a review November 15, 2017 02:01
mukherjee2
mukherjee2 approved these changes Nov 15, 2017
View reviewed changes
Copy link
Contributor

@mukherjee2 mukherjee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with this environment:
Node Version: 6.11.5
NPM Version: 3.10.10
Mac OS: 10.13
Appc CLI: 7.0.0-master.8
Appc CLI NPM: 4.2.11-2
Titanium SDK version: 7.0.0
Appcelerator Studio vers 4.10.0
Android 7.1.2
I created an app with nested views and did not see any crashes when using the back button. Passing review, but will close after user confirms that they do not see the issue any more as well.

@eric34 eric34 merged commit 3f3cbcf into tidev:master Nov 15, 2017
@drauggres drauggres mentioned this pull request May 7, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mukherjee2 mukherjee2 mukherjee2 approved these changes

@jquick-axway jquick-axway jquick-axway approved these changes

Assignees
No one assigned
Labels
android bug in-qe-testing 🕵
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@garymathews @build @mukherjee2 @jquick-axway @eric34 @sgtcoolguy