New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-25469] Android: Allow translucent theme to inherit custom theme attributes #9581
Conversation
android/cli/commands/_build.js
Outdated
@@ -3380,8 +3380,16 @@ AndroidBuilder.prototype.generateTheme = function generateTheme(next) { | |||
flags += '.Fullscreen'; | |||
} | |||
|
|||
let theme = flags; | |||
if (this.tiappAndroidManifest && this.tiappAndroidManifest.application && this.tiappAndroidManifest.application.theme) { | |||
if (theme.startsWith('@style/') && theme !== '@style/Theme.Titanium.Translucent') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe theme
should be this.tiappAndroidManifest.application.theme
in the condition?
Generated by 🚫 dangerJS |
FR Passed. When Studio Ver: 5.0.0.201712081732 |
TEST CASE
custom_theme.xml
tiapp.xml
app.js
JIRA Ticket