Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25424] Wrap music-related API's to prevent the requirement of non-used privacy-keys #9586

Closed
wants to merge 19 commits into from
Closed

[TIMOB-25424] Wrap music-related API's to prevent the requirement of non-used privacy-keys #9586

wants to merge 19 commits into from

Conversation

hansemannn
Copy link
Collaborator

@hansemannn
[TIMOB-25424] Fix a bunch of Ti.Media symbols
1045ab8 
# Conflicts:
#	iphone/Classes/MediaModule.h
#	iphone/Classes/MediaModule.m
#	iphone/Classes/defines.h
@hansemannn
Lint sources
56e7f27
@hansemannn hansemannn added this to the 7.0.0 milestone Nov 6, 2017
@hansemannn hansemannn self-assigned this Nov 6, 2017
vijaysingh-axway
vijaysingh-axway approved these changes Nov 10, 2017
View reviewed changes
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR passed.

@build build added the ios label Nov 17, 2017
@sgtcoolguy sgtcoolguy modified the milestones: 7.0.0, 7.0.1 Nov 29, 2017
@sgtcoolguy
Copy link
Contributor

sgtcoolguy commented Dec 14, 2017 •
edited

This PR won't build the test suite app for iOS, so I don't think it's ready for merge.

[ERROR] : �� �** BUILD FAILED **
[ERROR] : �� �The following build commands failed:
[ERROR] : �� �	CompileC build/Intermediates/mocha.build/Debug-iphonesimulator/mocha.build/Objects-normal/x86_64/MediaModule.o Classes/MediaModule.m normal x86_64 objective-c com.apple.compilers.llvm.clang.1_0.compiler
[ERROR] : �� �(1 failure)

@build
Copy link
Contributor

build commented Dec 14, 2017 •
edited

Fails
🚫

Tests have failed, see below for more information.
Messages
📖

💾 Here's the generated SDK zipfile.

Tests:

Classname Name Time Error
android.Titanium.Network.HTTPClient clearCookieUnaffectedCheck 60.029 Error: timeout of 60000ms exceeded

Generated by 🚫 dangerJS

@sgtcoolguy
Copy link
Contributor

manually merged to master

@sgtcoolguy sgtcoolguy closed this Dec 14, 2017
@hansemannn hansemannn deleted the TIMOB-25424 branch December 14, 2017 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vijaysingh-axway vijaysingh-axway vijaysingh-axway approved these changes

Assignees

@hansemannn hansemannn

Labels
bug in-qe-testing 🕵 ios no tests
Projects
None yet
Milestone
7.0.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hansemannn @sgtcoolguy @build @vijaysingh-axway @ewieberappc