Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25504] iOS: Fix default-image selection between iPhone 6/7 Plus and iPhone X #9592

Merged
merged 2 commits into from Nov 13, 2017
Merged

[TIMOB-25504] iOS: Fix default-image selection between iPhone 6/7 Plus and iPhone X #9592

merged 2 commits into from Nov 13, 2017

Conversation

hansemannn
Copy link
Collaborator

@hansemannn hansemannn added this to the 7.0.0 milestone Nov 13, 2017
@hansemannn hansemannn self-assigned this Nov 13, 2017
@build build added the ios label Nov 13, 2017
@build
Copy link
Contributor

build commented Nov 13, 2017

Fails
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.

Generated by 🚫 dangerJS

@ewieberappc
Copy link
Contributor

FR Passed. The correct images are now selected on iPhone X when both 736h and 2436h images are present.

@sgtcoolguy sgtcoolguy merged commit 5c9dbe5 into tidev:master Nov 13, 2017
@hansemannn hansemannn deleted the TIMOB-25504 branch November 13, 2017 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vijaysingh-axway vijaysingh-axway Awaiting requested review from vijaysingh-axway

Assignees

@hansemannn hansemannn

Labels
bug ios
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hansemannn @build @ewieberappc @sgtcoolguy