[TIMOB-25508] Avoid forced rebuild loop due to tiapp.xml navbar-hidden changed #9593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Property in tiapp.xml is written in kebab case instead of camel case.
sgtcoolguy
approved these changes
Nov 30, 2017
|
Will need to be cherry-picked to 7_0_X too once approved/merged. |
Generated by 🚫 dangerJS |
longton95
approved these changes
Dec 13, 2017
There was a problem hiding this comment.
FR passed.
Tested using test steps on the ticket, there is no force rebuild due to a navbar change
ENV
SDK Version : 7.0.0.GA, Local 7.0.1, Local 7.1.0
macOS Sierra 10.13.1
Nexus 6p (8.1.0)
android emulator (4.4.2, 6.0)
Appc CLI : 7.0.0
Appc NPM : 4.2.11
Node : v8.9.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-25508
Optional Description:
Property in tiapp.xml is written in kebab case instead of camel case.
Requires https://github.com/appcelerator/appc-cli-titanium/pull/252