Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Lowered min "targetSdkVersion" from 25 to 23. #9595

Merged
merged 1 commit into from Nov 13, 2017

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway jquick-axway commented Nov 13, 2017

JIRA: https://jira.appcelerator.org/browse/TIMOB-25510

Summary:
The Android min "targetSdkVersion" was bumped up from 23 to 25 in Titanium 6.2.2, but developers need the ability to target API Level 23 (aka: Android 6.0) in order to work-around Android 7.0's breaking changes (not all of them have been resolved yet). This change brings back API Level 23 targeting support.

Test:

  1. Add the below Android settings to your project's "tiapp.xml" file.
  2. Build the app for Android.
  3. Open the file: ./<YourProject>/build/android/AndroidManifest.xml
  4. Verify that the XML <uses-sdk> element's targetSdkVersion is set to 23.
<?xml version="1.0" encoding="UTF-8"?>
<ti:app xmlns:ti="http://ti.appcelerator.org">
	<android xmlns:android="http://schemas.android.com/apk/res/android">
		<manifest>
			<uses-sdk android:minSdkVersion="16" android:targetSdkVersion="23"/>
		</manifest>
	</android>
</ti:app>

Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

@lokeshchdhry
Copy link
Contributor

FR Passed.

  1. Build SDK has "android sdk": ">=23.x <=25.x".
  2. The app built to android device shows : [INFO] : Targeting Android SDK API: 23.
  3. The androidmanifest has android:targetSdkVersion="23".

Studio Ver: 4.10.0.201709271713
SDK Ver: 7.0.0 local build
OS Ver: 10.12.3
Xcode Ver: Xcode 8.3.3
Appc NPM: 4.2.10
Appc CLI: 6.3.0
Ti CLI Ver: 5.0.14
Alloy Ver: 1.10.7
Node Ver: 7.10.1
Java Ver: 1.8.0_101
Devices: ⇨ google Nexus 5 --- Android 6.0.1
⇨ google Nexus 6P --- Android 8.0.0

@lokeshchdhry lokeshchdhry merged commit bf30ea3 into tidev:master Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants