Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-25507] remove permission requirement for cache #9596

Merged
merged 4 commits into from Feb 22, 2018

Conversation

drauggres
Copy link
Contributor

@drauggres
Copy link
Contributor Author

should be labeled as "bug", not "improvement"

@build
Copy link
Contributor

build commented Dec 5, 2017

Messages
📖

🎉 Another contribution from our awesome community member, drauggres! Thanks again for helping us make Titanium SDK better. 👍

📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed Was able to see items stored in the cached in filesystem (tmp dir) for Android without
permission requirement for cache.

Test Steps:

  • Created a titanium project with the build form this PR
  • Added the following code in to the project
var win = Ti.UI.createWindow({
  title: 'AC-5274',
  layout: 'vertical',
  backgroundColor: '#fff'
});

var button = Ti.UI.createButton({
  center: {
    x: '50%',
    y: '50%'
  },
  title: 'clickMe'
});

button.addEventListener('click', function() {
  console.log('click');
  var image = Ti.UI.createImageView({
    width: Ti.UI.SIZE,
    height: Ti.UI.SIZE,
    image: 'http://docs.appcelerator.com/platform/latest/resources/images/icon_android.png'
  });
  win.add(image);
});

win.add(button);
win.open();
  • Ran the application
  • Pressed 'click me'
  • closed the application
  • pressed 'click me' again
  • checked the '//Android/data/<app_id>/cache/_tmp/remote-cache' directory using 'ES file explorer'
  • Was able to see cached items which were not seen using and older version of the SDK (7.0.2.GA)

Test Environment
APPC Studio: 5.0.0.201711280737
APPC CLI: 7.0.1
Device: Nexus 6p (8.1.0)
Operating System Name: Mac OS High Sierra
Operating System Version: 10.13
Node.js Version: 8.9.1

@ssjsamir ssjsamir merged commit 54ab479 into tidev:master Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants