Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-9680] Android: Fix TextField/TextArea focus/blur #9607

Merged
merged 5 commits into from Nov 16, 2017

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway jquick-axway commented Nov 16, 2017

Note:
This is a continuation of @maggieaxway's PR #9014. A new PR needed to be created since previous PR's remote branch appears to have been deleted (ie: shows "unknown repository").

JIRA: https://jira.appcelerator.org/browse/TIMOB-9680

Expected: To achieve same behaviour as iOS

Test case:

var win = Ti.UI.createWindow({backgroundColor : 'gray', layout: 'vertical'});
var tf = Ti.UI.createTextField({value: 'text'});
var btn = Ti.UI.createButton({title: 'focus'});
var btn2 = Ti.UI.createButton({title: 'blur'});
btn.addEventListener('click', function() {
   tf.focus();
});
btn2.addEventListener('click', function() {
   tf.blur();
});
win.add(tf);
win.add(btn);
win.add(btn2);
win.open();

@jquick-axway
Copy link
Contributor Author

@lokeshchdhry, this will need to be re-tested since the last PR's code was about 6 months old. We need to make sure that it still works now that it has been updated to 7.0.0.

@lokeshchdhry
Copy link
Contributor

FR Passed.

The focus & the blur method works as expected.

Studio Ver: 4.10.0.201709271713
OS Ver: 10.12.3
SDK Ver: 7.0.0 local build
Xcode Ver: Xcode 8.3.3
Appc NPM: 4.2.10
Appc CLI: 6.3.0
Ti CLI Ver: 5.0.14
Alloy Ver: 1.10.7
Node Ver: 7.10.1
Java Ver: 1.8.0_101
Devices: ⇨ google Nexus 6P --- Android 8.0.0
⇨ google Nexus 5 --- Android 6.0.1

Copy link
Contributor

@maggieaxway maggieaxway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR pass. Great job of creating the unit test. Thank you

@build build added the android label Nov 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants