[TIMOB-25522] iOS: Add "navigationWindow" property to Ti.UI.Window, add unit-tests for all nav-window API's #9608
Conversation
tests/Resources/ti.ui.window.test.js
Outdated
| win = null; | ||
| }); | ||
|
|
||
| it.ios('#navigationWindow', function () { |
There was a problem hiding this comment.
I've been trying to use a naming scheme so that #whatever is used to denote methods, .whatever is used to denote properties.
There was a problem hiding this comment.
Gotcha, will change!
tests/Resources/ti.ui.window.test.js
Outdated
| finish(); | ||
| }); | ||
|
|
||
| var nav = Ti.UI.iOS.createNavigationWindow({ |
There was a problem hiding this comment.
var declaration should always be at the top of the scope (or else eslint will complain, since vars are hoisted anyways)
So var nav; should go at the very top, then the assignment stays here.
tests/Resources/ti.ui.window.test.js
Outdated
| var should = require('./utilities/assertions'), | ||
| utilities = require('./utilities/utilities'); | ||
|
|
||
| describe('Titanium.UI.Window', function () { |
There was a problem hiding this comment.
rename this file to ti.ui.window.navigationwindow.addontest.js so it gets "added on" the existing suite rather than replaces the existing ti.ui.window tests.
There was a problem hiding this comment.
Alternatively, you could add a ti.ui.ios.navigationwindow.addontest.js for this create/property test and any future tests on that type (I see we have 3 methods that likely should have tests: http://docs.appcelerator.com/platform/latest/#!/api/Titanium.UI.iOS.NavigationWindow)
There was a problem hiding this comment.
How to deal with before, after, beforeEach and afterEach methods? Should I include those in the addons?
There was a problem hiding this comment.
Looks like to be safe on Android the before/after should stay. You don't check for, so don't need didFocus or before hook. I'd keep the after hook, and drop your explicit setting of win = null in the test (is that needed?)
There was a problem hiding this comment.
Okay, will do. Copied over the win = null statement, don't think it's needed as the proxy should clean up after itself.
There was a problem hiding this comment.
Decided to use ti.ui.ios.navigationwindow.addontest.js and will add unit-tests for the other ones as well to get some more basic coverage. And as Android / Windows will get parity on the navigation-window, they'll be happy to find existing unit-tests already.
hansemannn
changed the title
| @@ -41,6 +41,72 @@ describe('Titanium.UI.Window', function () { | |||
| } | |||
| win = null; | |||
| }); | |||
|
|
|||
| it.ios('#openWindow', function () { | |||
There was a problem hiding this comment.
FYI, you can just do describe.ios at the top to limit all sub-tests to iOS and avoid having to do it.ios on them all.
There was a problem hiding this comment.
Doing now, thx!
There was a problem hiding this comment.
FR Passed: Able to reference the current navigation-window using the "navigationWindow" instance property. From the following test case from https://jira.appcelerator.org/browse/TIMOB-25522:
var win = Ti.UI.createWindow({
backgroundColor: '#fff'
});
var nav = Ti.UI.iOS.createNavigationWindow({
window: win
});
var btn = Ti.UI.createButton({
title: 'Open next window'
});
btn.addEventListener('click', function() {
win.navigationWindow.openWindow(Ti.UI.createWindow({
title: 'Next Window!',
backgroundColor: 'green'
}));
});
win.add(btn);
nav.open();Test steps
- Created a build from this PR
- Created a titanium app
- Added the test case above
- Pressed 'open newt window'
- New window was opened
Test Environment
APPC Studio: 5.0.0.201712081732
APPC CLI: 7.0.3
iphone 6 plus (10.2)
Operating System Name: Mac OS High Sierra
Operating System Version: 10.13
Node.js Version: 8.9.1
Xcode 9.2
|
@sgtcoolguy I cannot figure out why the unit tests here are still failing. |
Generated by 🚫 dangerJS |
JIRA: https://jira.appcelerator.org/browse/TIMOB-25522