Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-25517] Android: TableViewProxy unable to create table view row proxy for object #9609

Merged
merged 7 commits into from Dec 20, 2017

Conversation

ypbnv
Copy link
Contributor

@ypbnv ypbnv commented Nov 16, 2017

JIRA: https://jira.appcelerator.org/browse/TIMOB-25517

Description:
Fixes TableView insertSectionAfter() method.

Test case:
app.js

var win = Ti.UI.createWindow();
var table = Ti.UI.createTableView();
win.add(table);
win.open();

var sectionFish = Ti.UI.createTableViewSection({ headerTitle: 'Fish' });
sectionFish.add(Ti.UI.createTableViewRow({ title: 'Cod' }));
sectionFish.add(Ti.UI.createTableViewRow({ title: 'Haddock' }));

table.insertSectionBefore(0, sectionFish);

With 6.3.0:
sectionFish is not added and an error is logged:
Unable to create table view row proxy for object, likely an error in the type of the object passed in...

@build
Copy link
Contributor

build commented Nov 16, 2017

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@sgtcoolguy
Copy link
Contributor

Can we add a test for this? Or maybe just see if Android now passes this one: https://github.com/appcelerator/titanium-mobile-mocha-suite/blob/master/Resources/ti.ui.tableview.test.js#L891

@ypbnv
Copy link
Contributor Author

ypbnv commented Nov 27, 2017

@sgtcoolguy Both tests (insertSectionBefore and insertSectionAfter) are passed on Android device and emulator now.

@build build added the android label Nov 29, 2017
…remove use of a 1s setTimeout at end of most tests
@sgtcoolguy sgtcoolguy added this to the 7.0.1 milestone Nov 29, 2017
@sgtcoolguy
Copy link
Contributor

NOTE: This will need to be cherry-picked to 7_0_X after being merged to master.

@build build added the android label Dec 11, 2017
@lokeshchdhry
Copy link
Contributor

FR Passed.

No Unable to create table view row proxy for object error seen & insertSectionBefore & insertSectionAfter works as expected. Also, checked with test app in the ticket.

Studio Ver: 5.0.0.201712081732
SDK Ver: 7.1.0 local build
OS Ver: 10.12.3
Xcode Ver: Xcode 8.3.3
Appc NPM: 4.2.11
Appc CLI: 7.0.0
Daemon Ver: 1.0.0
Ti CLI Ver: 5.0.14
Alloy Ver: 1.10.10
Node Ver: 8.9.1
Java Ver: 1.8.0_101
Devices: ⇨ google Nexus 5 --- Android 6.0.1
⇨ google Pixel --- Android 7.1.1

@lokeshchdhry lokeshchdhry merged commit b9b301d into tidev:master Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants