New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-25517] Android: TableViewProxy unable to create table view row proxy for object #9609
Conversation
Generated by 🚫 dangerJS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: Pass
Can we add a test for this? Or maybe just see if Android now passes this one: https://github.com/appcelerator/titanium-mobile-mocha-suite/blob/master/Resources/ti.ui.tableview.test.js#L891 |
@sgtcoolguy Both tests (insertSectionBefore and insertSectionAfter) are passed on Android device and emulator now. |
…remove use of a 1s setTimeout at end of most tests
NOTE: This will need to be cherry-picked to 7_0_X after being merged to master. |
FR Passed. No Studio Ver: 5.0.0.201712081732 |
JIRA: https://jira.appcelerator.org/browse/TIMOB-25517
Description:
Fixes TableView insertSectionAfter() method.
Test case:
app.js
With 6.3.0:
sectionFish is not added and an error is logged:
Unable to create table view row proxy for object, likely an error in the type of the object passed in...