Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25525] Android: Fixed TextField/TextArea focus bug that happens on 1st tap #9614

Merged
merged 5 commits into from Nov 17, 2017
Merged

[TIMOB-25525] Android: Fixed TextField/TextArea focus bug that happens on 1st tap #9614

merged 5 commits into from Nov 17, 2017

Conversation

jquick-axway
Copy link
Contributor

JIRA: https://jira.appcelerator.org/browse/TIMOB-25525

Notes:

  • Fixes issue where 1st tap on a TextField/TextArea is ignored and immediately loses focus. Only occurs when there are at least 2 focusable UI elements onscreen.
  • This issue was not introduce in a release to Titanium developers. (Was caught before RC.)

Test:
Run the test attached to TIMOB-25525.

@jquick-axway
[TIMOB-25525] Android: Fixed bug where tapping TextField/TextArea cau…
4ee0106 
…ses it to immediately lose focus when multiple fields exist.
@jquick-axway jquick-axway added this to the 7.0.0 milestone Nov 17, 2017
@jquick-axway
Copy link
Contributor Author

@maggieaxway, I'm removing the initFocus code that was added in the PR #9607. Do you remember what those changes were for? I've ran several tests with this code removed and I'm not seeing any issues, but it's definitely causing the issue mentioned by this PR.

maggieaxway
maggieaxway approved these changes Nov 17, 2017
View reviewed changes
Copy link
Contributor

@maggieaxway maggieaxway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR PASS

@build build added the android label Nov 17, 2017
@build
Copy link
Contributor

build commented Nov 17, 2017 •
edited

Fails
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.
Messages
📖

👍 Hey!, You deleted more code than you added. That's awesome!

Generated by 🚫 dangerJS

@mukherjee2 mukherjee2 self-requested a review November 17, 2017 19:40
mukherjee2
mukherjee2 approved these changes Nov 17, 2017
View reviewed changes
Copy link
Contributor

@mukherjee2 mukherjee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR passed.
Node Version: 8.9.1
NPM Version: 5.5.1
Mac OS: 10.13
Appc CLI: 7.0.0-master.27
Appc CLI NPM: 4.2.11-2
Titanium SDK version: 7.0.0
Appcelerator Studio vers 4.10.0
Android 7.1.2

@build build added the android label Nov 17, 2017
@sgtcoolguy sgtcoolguy merged commit fd8b436 into tidev:master Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mukherjee2 mukherjee2 mukherjee2 approved these changes

@maggieaxway maggieaxway maggieaxway approved these changes

Assignees
No one assigned
Labels
android bug in-qe-testing 🕵
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jquick-axway @build @mukherjee2 @maggieaxway @sgtcoolguy