[TIMOB-25552] Android: Fixed nested scrolling within disabled ScrollView to propagate to parent view #9625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iew to propagate to parent view. - Fixed in ScrollView, TableView, and ListView. (I don't think it's possible to reproduce in TableView and ListView though.)
Generated by 🚫 dangerJS |
longton95
approved these changes
Feb 27, 2018
There was a problem hiding this comment.
FR passed.
Tested using the test case the ticket, The outer scrollView now scrolls correctly.
ENV
SDK Version : 7.0.2.GA, Local 7.2.0
macOS Sierra 10.13.3
Google Pixel 2 XL (8.1.0)
android emulator (7.1.1)
Appc CLI : 7.0.3-master.10
Appc NPM : 4.2.12
Node : v8.9.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-25552
Test:
Run the test attached to TIMOB-25552.