New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-20522] Use FusedLocationProviderClient for Ti.Geolocation #9634
Conversation
b0665f6
to
7ce1881
Compare
@garymathews Does this also affect #9633? |
ca5a9d5
to
e6630b3
Compare
@hansemannn #9633 is not affected by this |
@@ -395,6 +428,8 @@ properties: | |||
type: Number | |||
permission: read-only | |||
platforms: [android, iphone, ipad] | |||
deprecated: | |||
since: "2.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think they are deprecated for iOS. Maybe only deprecate and remove for Android?
e9d3506
to
aa2c954
Compare
2b1860c
to
6a6cc23
Compare
427e70d
to
1c34329
Compare
6f6943a
to
9712e59
Compare
e1a9da8
to
1c2288d
Compare
1c2288d
to
1698d84
Compare
1698d84
to
1f271a6
Compare
Generated by 🚫 dangerJS |
Oops forgot to comment before merging. Checked the changes & geolocation works as expected in emulator without google playservices. Studio Ver: 5.0.0.201712081732 |
FusedLocationProviderClient
whenti.playservices
module is included intiapp.xml
, falling back to previous behavior if not availableTEST CASE
NOTE: The play services libraries for the Geolocation module are only required to compile the SDK. They are not included with titanium builds and won't cause conflicts with
ti.playservices
. However, they will need updating if the Google API changes.JIRA Ticket