Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25569] Reference Hyperloop 3.0.1 #9636

Merged
merged 1 commit into from Nov 29, 2017
Merged

[TIMOB-25569] Reference Hyperloop 3.0.1 #9636

merged 1 commit into from Nov 29, 2017

Conversation

hansemannn
Copy link
Collaborator

JIRA: https://jira.appcelerator.org/browse/TIMOB-25569

Highly recommending for 7.0.0 GA, but using 7.0.1 milestone for now to prevent unexpected new tickets 馃檪.

@hansemannn hansemannn added the bug label Nov 29, 2017
@hansemannn hansemannn self-assigned this Nov 29, 2017
@hansemannn hansemannn added this to the 7.0.1 milestone Nov 29, 2017
@build
Copy link
Contributor

build commented Nov 29, 2017

Fails
馃毇

Tests have failed, see below for more information.
Messages
馃摉

馃捑 Here's the generated SDK zipfile.

Tests:

Classname Name Time Error
android.Titanium.Network.HTTPClient clearCookieUnaffectedCheck 60.02 Error: timeout of 60000ms exceeded
android.Titanium.Network.Socket.TCP #connect() and receive data 5.04 Error: done() invoked with non-Error: [object Object]

Generated by 馃毇 dangerJS

sgtcoolguy
sgtcoolguy approved these changes Nov 29, 2017
View reviewed changes
Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eric34 Do we want this merged in for 7.0.0? If not we'll have to wait to merge it against a 7_0_X branch (once that is created).

@sgtcoolguy sgtcoolguy merged commit 8ef7d6e into tidev:master Nov 29, 2017
@sgtcoolguy sgtcoolguy modified the milestones: 7.0.1, 7.0.0 Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgtcoolguy sgtcoolguy sgtcoolguy approved these changes

Assignees

@eric34 eric34

@hansemannn hansemannn

Labels
bug
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hansemannn @build @sgtcoolguy @eric34