[TIMOB-25560] : iOS extendSafeArea property not behave properly if tabBarHidden = true or navBarHidden = true #9638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bBarHidden = true or navBarHidden = true
|
Looks good! Please add unit-tests as well and ensure the sources are linted. |
Generated by 🚫 dangerJS |
|
@hansemannn did a quick test and it fixes the issue I reported earlier |
hansemannn
approved these changes
Dec 4, 2017
mukherjee2
approved these changes
Dec 13, 2017
There was a problem hiding this comment.
Node Version: 8.9.1
NPM Version: 5.5.1
Mac OS: 10.13.1
Appc CLI: 7.0.0
Appc CLI NPM: 4.2.11
Titanium SDK version: 7.0.0 + artifacts from this PR
Appcelerator Studio vers 5.0.0
Passed FR. I was able to see the text at the top and bottom clearly on iPhone X simulator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-25560