Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7_0_X][TIMOB-25580] Android: Prevent EVENT_RETURN firing twice #9653

Merged
merged 3 commits into from Dec 5, 2017
Merged

[7_0_X][TIMOB-25580] Android: Prevent EVENT_RETURN firing twice #9653

merged 3 commits into from Dec 5, 2017

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews added this to the 7.0.0 milestone Dec 4, 2017
@build build added the android label Dec 4, 2017
@build
Copy link
Contributor

build commented Dec 4, 2017 •
edited

Fails
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.
Messages
📖

👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

jquick-axway
jquick-axway approved these changes Dec 4, 2017
View reviewed changes
Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@build build added the android label Dec 5, 2017
@garymathews garymathews changed the base branch from master to 7_0_X December 5, 2017 17:58
@build build added the android label Dec 5, 2017
@lokeshchdhry
Copy link
Contributor

FR Passed.

return event is fired only once.
return event is fired after next & done for textfields.

Studio Ver: 5.0.0.201711301752
SDK Ver: 7.0.0.v20171205101304
OS Ver: 10.12.3
Xcode Ver: Xcode 8.3.3
Appc NPM: 4.2.11-4
Appc CLI: 7.0.0-master.56
Ti CLI Ver: 5.0.14
Alloy Ver: 1.10.9
Node Ver: 8.9.1
Java Ver: 1.8.0_101
Devices: ⇨ google Nexus 5 --- Android 6.0.1
⇨ google Pixel --- Android 7.1.1

@lokeshchdhry lokeshchdhry merged commit f09dec4 into tidev:7_0_X Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jquick-axway jquick-axway jquick-axway approved these changes

Assignees
No one assigned
Labels
android bug in-qe-testing 🕵
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@garymathews @build @lokeshchdhry @jquick-axway