Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7_0_X][TIMOB-25477] Android: Fixed bug where tapping right-aligned TextField not always receiving focus as of 6.2.2 #9662

Merged
merged 5 commits into from Dec 14, 2017
Merged

[7_0_X][TIMOB-25477] Android: Fixed bug where tapping right-aligned TextField not always receiving focus as of 6.2.2 #9662

merged 5 commits into from Dec 14, 2017

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway
[TIMOB-25477] Android: Fixed bug where tapping right-aligned TextFiel…
a8a7be7 
…ds don't always receive focus.

- Added a tap/drag tolerance. Touch-move event must exceed min distance before it dispatches scroll events to parent view.
- Optimized touch-move code to skip nested scrolling calculations if startNestedScroll() returns false.
@jquick-axway jquick-axway added this to the 7.0.1 milestone Dec 7, 2017
@mukherjee2 mukherjee2 self-requested a review December 11, 2017 21:38
@build
Copy link
Contributor

build commented Dec 12, 2017 •
edited

Fails
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.
Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@build build added the android label Dec 12, 2017
mukherjee2
mukherjee2 approved these changes Dec 12, 2017
View reviewed changes
Copy link
Contributor

@mukherjee2 mukherjee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed FR. Details are in PR for master.

@build build added the android label Dec 14, 2017
@mukherjee2 mukherjee2 merged commit ee87c7b into tidev:7_0_X Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mukherjee2 mukherjee2 mukherjee2 approved these changes

@garymathews garymathews Awaiting requested review from garymathews

Assignees
No one assigned
Labels
android bug no tests
Projects
None yet
Milestone
7.0.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jquick-axway @build @mukherjee2