Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25424] (7_0_X) Wrap music-related API's to prevent the requirement of non-used privacy-keys #9665

Merged
merged 12 commits into from Dec 14, 2017
Merged

[TIMOB-25424] (7_0_X) Wrap music-related API's to prevent the requirement of non-used privacy-keys #9665

merged 12 commits into from Dec 14, 2017

Conversation

hansemannn
Copy link
Collaborator

@hansemannn
[TIMOB-25424] Fix a bunch of Ti.Media symbols
608df5f 
# Conflicts:
#	iphone/Classes/MediaModule.h
#	iphone/Classes/MediaModule.m
#	iphone/Classes/defines.h

# Conflicts:
#	iphone/Classes/defines.h
@hansemannn
Lint sources
e7f5fa2 
# Conflicts:
#	iphone/Classes/MediaModule.m
@hansemannn
[TIMOB-25424] Fix missing wraps
0a3df0b
@hansemannn
[TIMOB-25424] More wrapping
0080295 
# Conflicts:
#	iphone/Classes/MediaModule.m
@hansemannn
Formatting
dc54eb6 
# Conflicts:
#	iphone/Classes/MediaModule.m
@hansemannn
[TIMOB-25424] Wrap unused declarations
992d6b8
@hansemannn
[TIMOB-25424] Fix last declaration
17de56f
@hansemannn hansemannn added this to the 7.0.1 milestone Dec 7, 2017
@hansemannn hansemannn self-assigned this Dec 7, 2017
@build build added the ios label Dec 12, 2017
@build
Copy link
Contributor

build commented Dec 12, 2017 •
edited

Fails
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.
Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@build build added the ios label Dec 14, 2017
@hansemannn
Copy link
Collaborator Author

@sgtcoolguy Interesting that danger complains here but not on master. Are the "no tests" changes master only?

@sgtcoolguy
Copy link
Contributor

yeah, they're only on master.

@sgtcoolguy sgtcoolguy merged commit e400989 into tidev:7_0_X Dec 14, 2017
@hansemannn hansemannn deleted the TIMOB-25424-7_0_X branch December 14, 2017 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hansemannn hansemannn

Labels
in-qe-testing 🕵 ios no tests
Projects
None yet
Milestone
7.0.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hansemannn @build @sgtcoolguy @ewieberappc