Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7_0_X][TIMOB-25468] Android: Fix event source property #9686

Merged
merged 4 commits into from Dec 15, 2017

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews added this to the 7.0.1 milestone Dec 13, 2017
@build build added the android label Dec 14, 2017
@build
Copy link
Contributor

build commented Dec 14, 2017

Fails
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@lokeshchdhry
Copy link
Contributor

lokeshchdhry commented Dec 15, 2017

FR Passed.

According to @garymathews the errors (commented in the master PR) are due to soasta & not related to this PR. There will be another PR for it.

source property is included with the events.

Studio Ver: 5.0.0.201712081732
SDK Ver: 7.0.1 local build
OS Ver: 10.12.3
Xcode Ver: Xcode 8.3.3
Appc NPM: 4.2.11
Appc CLI: 7.0.0
Daemon Ver: 1.0.0
Ti CLI Ver: 5.0.14
Alloy Ver: 1.10.10
Node Ver: 8.9.1
Java Ver: 1.8.0_101
Devices: ⇨ google Nexus 5 --- Android 6.0.1
⇨ google Pixel --- Android 7.1.1

@build build added the android label Dec 15, 2017
@eric34 eric34 merged commit 3307d0d into tidev:7_0_X Dec 15, 2017
@build build added the android label Dec 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants