Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-25607] Remove deprecated Ti.map API #9687

Merged
merged 1 commit into from Dec 14, 2017

Conversation

sgtcoolguy
Copy link
Contributor

JIRA: https://jira.appcelerator.org/browse/TIMOB-25607

This was deprecated in 3.2.0(!) and moved out tot he native module we ship with the SDK. It's time for it to go.

@sgtcoolguy sgtcoolguy added this to the 7.1.0 milestone Dec 13, 2017
@build
Copy link
Contributor

build commented Dec 13, 2017

Messages
📖

👍 Hey!, You deleted more code than you added. That's awesome!

📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

Copy link
Collaborator

@hansemannn hansemannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important PR, go for it! I think the docs even quote:

Support for the Titanium.Map module in iOS and Android was removed in Release 3.2.0.

So I don't think anyone expects it to work anymore. Also, the modules got tons of fixes and new improvements, so there are 0 reasons to keep it.

@sgtcoolguy sgtcoolguy merged commit 6b55684 into tidev:master Dec 14, 2017
@sgtcoolguy sgtcoolguy deleted the remove-maps-module branch December 14, 2017 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants