Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7_0_X][TIMOB-25469] Android: Allow translucent theme to inherit custom theme attributes #9688

Merged
merged 5 commits into from Dec 15, 2017
Merged

[7_0_X][TIMOB-25469] Android: Allow translucent theme to inherit custom theme attributes #9688

merged 5 commits into from Dec 15, 2017

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews added this to the 7.0.1 milestone Dec 13, 2017
@build
Copy link
Contributor

build commented Dec 14, 2017 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@lokeshchdhry
Copy link
Contributor

FR Passed.

When backgroundColor is set to transparent the custom theme gets applied successfully.

Studio Ver: 5.0.0.201712081732
SDK Ver: 7.0.1 local build
OS Ver: 10.12.3
Xcode Ver: Xcode 8.3.3
Appc NPM: 4.2.11
Appc CLI: 7.0.0
Daemon Ver: 1.0.0
Ti CLI Ver: 5.0.14
Alloy Ver: 1.10.10
Node Ver: 8.9.1
Java Ver: 1.8.0_101
Devices: ⇨ google Nexus 5 --- Android 6.0.1
⇨ google Pixel --- Android 7.1.1

@lokeshchdhry lokeshchdhry merged commit 19ea571 into tidev:7_0_X Dec 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
android bug
Projects
None yet
Milestone
7.0.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@garymathews @build @lokeshchdhry @eric34