Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-25654] Remove duplicate key from Geolocation logging #9702

Closed
wants to merge 1 commit into from

Conversation

ewanharris
Copy link
Collaborator

@ewanharris ewanharris commented Jan 8, 2018

JIRA: https://jira.appcelerator.org/browse/TIMOB-25654

Steps to reproduce

  • Add the code below to an app.js and build to iOS
Ti.Geolocation.requestLocationPermissions(Ti.Geolocation.AUTHORIZATION_ALWAYS, function(e) {
    console.log(e);
});

Expected

[ERROR] The NSLocationAlwaysUsageDescription, NSLocationWhenInUseUsageDescription and NSLocationAlwaysAndWhenInUseUsageDescription key must be defined in your tiapp.xml in order to request this permission. should be logged

Current

[ERROR] The NSLocationAlwaysAndWhenInUseUsageDescription, NSLocationAlwaysUsageDescription and NSLocationAlwaysAndWhenInUseUsageDescription key must be defined in your tiapp.xml in order to request this permission. is logged

@build
Copy link
Contributor

build commented Jan 8, 2018

Fails
🚫

Tests have failed, see below for more information.

Messages
📖

💾 Here's the generated SDK zipfile.

Tests:

Classname Name Time Error
android.Titanium.Geolocation forwardGeocoder 60.048 Error: timeout of 60000ms exceeded
ios.Titanium.Media.VideoPlayer Close window containing a video player (TIMOB-25574) 2.806 file:///Users/build/Libra

Generated by 🚫 dangerJS

@hansemannn
Copy link
Collaborator

hansemannn commented Jan 9, 2018

@ewanharris Silly error from myself. Please create a JIRA-ticket to have a minimum track of this.

@ewanharris ewanharris changed the title Remove duplicate key from Geolocation logging [TIMOB-25654] Remove duplicate key from Geolocation logging Jan 9, 2018
@ewanharris
Copy link
Collaborator Author

@hansemannn jira made and updated branch

@build build added the ios label Jan 9, 2018
@hansemannn
Copy link
Collaborator

I cannot merge..random test-failures again... @sgtcoolguy @eric34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants