Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7_0_X][TIMOB-25565] Prevent auto-focus callback from taking multiple pictures #9706

Merged
merged 8 commits into from Jan 24, 2018
Merged

[7_0_X][TIMOB-25565] Prevent auto-focus callback from taking multiple pictures #9706

merged 8 commits into from Jan 24, 2018

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews changed the title [TIMOB-25565] Prevent auto-focus callback from taking multiple pictures [7_0_X][TIMOB-25565] Prevent auto-focus callback from taking multiple pictures Jan 8, 2018
@build build added the android label Jan 8, 2018
@build
Copy link
Contributor

build commented Jan 8, 2018 •
edited

Fails
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.
Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@build build added the android label Jan 9, 2018
jquick-axway
jquick-axway reviewed Jan 9, 2018
View reviewed changes
Copy link
Contributor

@jquick-axway jquick-axway left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation for comment blocks /** ... */ got screwed up compared to master. They're using spaces instead of tabs. Not required to be fixed since this will be the last 7.0.X branch change, but might it's an odd clang-format difference.

jquick-axway
jquick-axway approved these changes Jan 9, 2018
View reviewed changes
Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@lokeshchdhry
Copy link
Contributor

FR Passed.

Success callback is fired only once on android 7.1.1 & 6.0.1. Asked the customer to check on his Moto G4 (as we do not have the device) & it works fine for him.

Studio Ver: 5.0.0.201712081732
SDK Ver: 7.0.2 local build
OS Ver: 10.13.2
Xcode Ver: Xcode 9.2
Appc NPM: 4.2.11
Appc CLI: 7.0.1
Daemon Ver: 1.0.1
Ti CLI Ver: 5.0.14
Alloy Ver: 1.10.10
Node Ver: 8.9.1
NPM Ver: 5.5.1
Java Ver: 1.8.0_101
Devices: google Pixel --- Android 7.1.1
google Nexus 5 --- Android 6.0.1
Moto G4 --- Customer device

@lokeshchdhry lokeshchdhry merged commit 94cd629 into tidev:7_0_X Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jquick-axway jquick-axway jquick-axway approved these changes

Assignees
No one assigned
Labels
android bug in-qe-testing 🕵 needs tests 🚨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@garymathews @build @lokeshchdhry @jquick-axway @eric34