Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7_0_X][TIMOB-25518][TIMOB-25506] Android: Improve client validation #9708

Merged
merged 9 commits into from Jan 24, 2018
Merged

[7_0_X][TIMOB-25518][TIMOB-25506] Android: Improve client validation #9708

merged 9 commits into from Jan 24, 2018

Conversation

garymathews
Copy link
Contributor

@build build added the android label Jan 9, 2018
@build
Copy link
Contributor

build commented Jan 9, 2018 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

jquick-axway
jquick-axway approved these changes Jan 9, 2018
View reviewed changes
Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@build build added the android label Jan 16, 2018
@lokeshchdhry
Copy link
Contributor

FR Passed.

Since this is just a validation change the http unit tests are sufficient.

Studio Ver: 5.0.0.201712081732
SDK Ver: 7.0.2 local build
OS Ver: 10.13.2
Xcode Ver: Xcode 9.2
Appc NPM: 4.2.11
Appc CLI: 7.0.1
Daemon Ver: 1.0.1
Ti CLI Ver: 5.0.14
Alloy Ver: 1.10.10
Node Ver: 8.9.1
NPM Ver: 5.5.1
Java Ver: 1.8.0_101
Devices: ⇨ google Pixel XL --- Android 8.0.0
⇨ google Nexus 5 --- Android 6.0.1

@build build added the android label Jan 19, 2018
@lokeshchdhry
Copy link
Contributor

lokeshchdhry commented Jan 22, 2018 •
edited

@garymathews , looks like there is a test failure https://jenkins.appcelerator.org/blue/organizations/jenkins/titanium-sdk%2Ftitanium_mobile/detail/PR-9708/12/tests.
Can you please take a look at it.

@build build added the android label Jan 23, 2018
@eric34 eric34 merged commit d98793c into tidev:7_0_X Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jquick-axway jquick-axway jquick-axway approved these changes

Assignees
No one assigned
Labels
android bug in-qe-testing 🕵 no tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@garymathews @build @lokeshchdhry @jquick-axway @eric34 @ssjsamir