Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7_0_X][TIMOB-25541] Android: Use ContentProvider in EmailDialog #9709

Merged
merged 9 commits into from Jan 19, 2018
Merged

[7_0_X][TIMOB-25541] Android: Use ContentProvider in EmailDialog #9709

merged 9 commits into from Jan 19, 2018

Conversation

jquick-axway
Copy link
Contributor

alg and others added 4 commits January 8, 2018 17:48
@alg @jquick-axway
Fixing email dialog crashing on Android 8
8c3bd06 
The same issue with file URI's being sent directly is fixed by replacing direct URI's with content provider URIs.
@sgtcoolguy @jquick-axway
Add line jquick suggested in his code review
7073c13
@jquick-axway
[TIMOB-25541] Android: Finished fixing issue where e-mail dialog fail…
fb17a65 
…s to attach files on Android 7.0 and higher.

Also done the following:
- Now falls-back to writing to sandboxed temp directory if unable to write to external storage.
- Improved error log message when blobs failed to attach.
@jquick-axway
Android: Updated code formatting for [TIMOB-25541]
57c6126
@jquick-axway jquick-axway added this to the 7.0.2 milestone Jan 9, 2018
@build build added the android label Jan 9, 2018
@build
Copy link
Contributor

build commented Jan 9, 2018 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@lokeshchdhry
Copy link
Contributor

FR Passed

Verified on android 8.0, 7.1.1, 6.0.1, 4.4.2

For https://jira.appcelerator.org/browse/TIMOB-23482:

  1. Clicking on send Email open up the chooser.
  2. If Outlook is installed & selected it opens up the email dialog.
  3. The 2 attachments File1.txt & File2.txt are attached successfully.
  4. The recipients & message body are seen as well.

For https://jira.appcelerator.org/browse/TIMOB-25541:

  1. On android 7.0 & above, clicking on send Email open up the chooser.
  2. If Outlook is installed & selected it opens up the email dialog.
  3. The 2 attachments File1.txt & File2.txt are attached successfully.
  4. The recipients & message body are seen as well.
  5. Same is seen for Gmail.

Studio Ver: 5.0.0.201712081732
SDK Ver: 7.0.2 local build
OS Ver: 10.13.2
Xcode Ver: Xcode 9.2
Appc NPM: 4.2.11
Appc CLI: 7.0.1
Daemon Ver: 1.0.1
Ti CLI Ver: 5.0.14
Alloy Ver: 1.10.10
Node Ver: 8.9.1
NPM Ver: 5.5.1
Java Ver: 1.8.0_101
Devices: ⇨ google Pixel --- Android 7.1.1
⇨ google Nexus 5 --- Android 6.0.1
Emulators: Android 8.0, 4.4.2

@lokeshchdhry
Copy link
Contributor

@jquick-axway , Can you please look at the failures in tests.

@build build added the android label Jan 17, 2018
@lokeshchdhry lokeshchdhry merged commit 51102be into tidev:7_0_X Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garymathews garymathews Awaiting requested review from garymathews

Assignees
No one assigned
Labels
android bug community 🔥
Projects
None yet
Milestone
7.0.2
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jquick-axway @build @lokeshchdhry @alg @sgtcoolguy @garymathews