Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-17572] iOS: Fix activity indicator animation in list items #9717

Merged
merged 6 commits into from Jan 23, 2018
Merged

[TIMOB-17572] iOS: Fix activity indicator animation in list items #9717

merged 6 commits into from Jan 23, 2018

Conversation

hansemannn
Copy link
Collaborator

@hansemannn hansemannn added this to the 7.0.2 milestone Jan 10, 2018
@hansemannn hansemannn self-assigned this Jan 10, 2018
@build build added the ios label Jan 15, 2018
vijaysingh-axway
vijaysingh-axway reviewed Jan 15, 2018
View reviewed changes
iphone/Classes/TiUIListItem.m
@@ -91,6 +94,21 @@ - (void)prepareForReuse
{
RELEASE_TO_NIL(_dataItem);
[super prepareForReuse];

#ifdef USE_TI_UIACTIVITYINDICATOR
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this issue not in TiUITableView ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue was only described in Ti.UI.ListView because the developer can re-animate the indicator inside the Ti.UI.TableView as it's children are not hold virtually. As I didn't see any comparable issue on JIRA, I only made it for this one for now (and because we recommend to use Ti.UI.ListView for performant usages).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okey.

vijaysingh-axway
vijaysingh-axway approved these changes Jan 15, 2018
View reviewed changes
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cr and FT passed.

@build build added the ios label Jan 16, 2018
@mukherjee2 mukherjee2 self-requested a review January 17, 2018 16:48
mukherjee2
mukherjee2 approved these changes Jan 17, 2018
View reviewed changes
Copy link
Contributor

@mukherjee2 mukherjee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed FR. Details in master PR.

@build build added the ios label Jan 17, 2018
@mukherjee2
Copy link
Contributor

I added "in-qe-testing" label back as per our discussion in standup.

@tidev tidev deleted a comment from build Jan 17, 2018
@build build added the ios label Jan 17, 2018
@build
Copy link
Contributor

build commented Jan 17, 2018 •
edited

Fails
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.
Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@mukherjee2
Copy link
Contributor

@hansemannn "Merge" button is still disabled. Should this one be force merged?

@hansemannn
Copy link
Collaborator Author

@mukherjee2 Random Android unit-test failure, no idea who should merge that. I can‘t, sorry.

@build build added the ios label Jan 23, 2018
@eric34 eric34 merged commit 2af7346 into tidev:7_0_X Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mukherjee2 mukherjee2 mukherjee2 approved these changes

@vijaysingh-axway vijaysingh-axway vijaysingh-axway approved these changes

Assignees

@hansemannn hansemannn

Labels
bug in-qe-testing 🕵 ios no tests
Projects
None yet
Milestone
7.0.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hansemannn @mukherjee2 @build @vijaysingh-axway @eric34