Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-25667] Android: Added TableView "scrollable" property support #9728

Merged
merged 9 commits into from May 9, 2018

Conversation

jquick-axway
Copy link
Contributor

JIRA: https://jira.appcelerator.org/browse/TIMOB-25667

Test:

  1. Build and run the below code on an Android device.
  2. Verify that you can scroll the TableView up/down.
  3. Tap the "Disable Scrolling" button in the bottom-right corner.
  4. Verify that you cannot scroll the TableView.
  5. Tap the "Enable Scrolling" button in the bottom-right corner.
  6. Verify that you can scroll the TableView up/down.
var window = Ti.UI.createWindow();
var tableData = [];
for (var index = 1; index <= 100; index++) {
	var row = Ti.UI.createTableViewRow({ title: "Row " + index.toString() });
	tableData.push(row);
}
var tableView = Ti.UI.createTableView(
{
	data: tableData,
	scrollable: true,
});
window.add(tableView);
function createButtonText() {
	return tableView.scrollable ? "Disable Scrolling" : "Enable Scrolling";
}
var button = Ti.UI.createButton(
{
	title: createButtonText(),
	right: "5dp",
	bottom: "5dp",
});
button.addEventListener("click", function(e) {
	tableView.scrollable = !tableView.scrollable;
//	tableView.setScrollable(!tableView.getScrollable());
	button.title = createButtonText();
});
window.add(button);
window.open();

Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

@garymathews
Copy link
Contributor

@jquick-axway Test case needs updating

@lokeshchdhry
Copy link
Contributor

FR Passed.

Tableview's scrollable property works as expected.

Studio Ver: 5.1.0.201804230827
SDK Ver: 7.2.0 local build
OS Ver: 10.13.4
Xcode Ver: Xcode 9.3
Appc NPM: 4.2.13
Appc CLI: 7.0.3
Daemon Ver: 1.1.1
Ti CLI Ver: 5.1.0
Alloy Ver: 1.12.0
Node Ver: 8.9.1
NPM Ver: 5.5.1
Java Ver: 10
Devices: ⇨ google Nexus 5 --- Android 6.0.1
⇨ google Nexus 6P --- Android 8.0.0
Emulator: ⇨ Android 4.1.2

@build
Copy link
Contributor

build commented May 9, 2018

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@lokeshchdhry lokeshchdhry merged commit 6de2e59 into tidev:master May 9, 2018
@sgtcoolguy sgtcoolguy modified the milestones: 7.2.0, 7.3.0 May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants