Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-25646]: iOS After Listview Search overlay not appearing #9730

Merged
merged 17 commits into from Jan 23, 2018

Conversation

vijaysingh-axway
Copy link
Contributor

@build build added the ios label Jan 16, 2018
@mukherjee2 mukherjee2 self-requested a review January 16, 2018 19:21
@build build added the ios label Jan 17, 2018
@tidev tidev deleted a comment from build Jan 17, 2018
@build build added the ios label Jan 17, 2018
@build
Copy link
Contributor

build commented Jan 17, 2018

Messages
📖

👍 Hey!, You deleted more code than you added. That's awesome!

📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@hansemannn
Copy link
Collaborator

@vijaysingh-axway Can you address the linting errors in TiUIListView.m?

@vijaysingh-axway
Copy link
Contributor Author

@hansemannn, I have already checked on this and couldn't find anything. I ran the clang-format command, but no success. Any suggestion?

@mukherjee2
Copy link
Contributor

@vijaysingh-axway I am not able to download the artifact to do FR. Can you please look at the issue with the commit?

@hansemannn
Copy link
Collaborator

@sgtcoolguy (and Alan, does he has Github?): It looks like a recent change on the clang-format configuration broke some of the iOS validation. It moved some object pointer from -> to -> (with a space). This cannot be fixed locally as clang-format -i -style=file <file> does not detect it. What do we do here?

@vijaysingh-axway
Copy link
Contributor Author

@mukherjee2 The build is failing due to linting issue. Hans has tried to fixed, but still issue is there. As Hans has mentioned, some change on clang-format has broken iOS validation. Let's see what Chris Williams suggest.

@sgtcoolguy
Copy link
Contributor

Well... is there any reason you can't fix this manually?

I don't believe there's been any change in clang-format's config recently.

@build build added the ios label Jan 18, 2018
@sgtcoolguy
Copy link
Contributor

@mukherjee2 lint issues have been fixed, should be able to grab the SDK to test now.

@build build added the ios label Jan 22, 2018
Copy link
Contributor

@mukherjee2 mukherjee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed FR. Details are in backport PR.

@mukherjee2 mukherjee2 merged commit 6140e3c into tidev:master Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants