New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-25646]: iOS After Listview Search overlay not appearing #9730
Conversation
Generated by 🚫 dangerJS |
@vijaysingh-axway Can you address the linting errors in TiUIListView.m? |
@hansemannn, I have already checked on this and couldn't find anything. I ran the clang-format command, but no success. Any suggestion? |
@vijaysingh-axway I am not able to download the artifact to do FR. Can you please look at the issue with the commit? |
@sgtcoolguy (and Alan, does he has Github?): It looks like a recent change on the clang-format configuration broke some of the iOS validation. It moved some object pointer from |
@mukherjee2 The build is failing due to linting issue. Hans has tried to fixed, but still issue is there. As Hans has mentioned, some change on clang-format has broken iOS validation. Let's see what Chris Williams suggest. |
Well... is there any reason you can't fix this manually? I don't believe there's been any change in clang-format's config recently. |
@mukherjee2 lint issues have been fixed, should be able to grab the SDK to test now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed FR. Details are in backport PR.
https://jira.appcelerator.org/browse/TIMOB-25646