[TIMOB-25672] iOS: Fix core-SDK warnings, leaks and possible crashes #9733
Conversation
hansemannn
changed the title
| @@ -186,7 +188,6 @@ - (void)viewWillAttach | |||
|
|
|||
| - (void)viewDidDetach | |||
| { | |||
| [self removeNotificationObserver]; | |||
There was a problem hiding this comment.
TiMediaVideoPlayerProxy related unit test is crashing sending message -
"Cannot update for observer <TiMediaVideoPlayerProxy 0x7fb2ed044a00> for the key path "player.status" from <AVPlayerViewController 0x7fb2ed033800>, most likely because the value for the key "player" has changed without an appropriate KVO notification being sent. Check the KVO-compliance of the AVPlayerViewController class."
You can see more detail in builds iOS unit test log.
There was a problem hiding this comment.
Jenkins actually passes the tests, but fails later. Which test did it mention?
There was a problem hiding this comment.
Just reproduced it, adding a test-case for it in my test-suite as well.
There was a problem hiding this comment.
Fixed as part of 31182c6
|
@hansemannn Can you resolve conflict please? |
|
Passed FR using this environment: Validated by building and launching app on device. I observed no warnings or memory leaks using Instruments. |
Generated by 🚫 dangerJS |
JIRA: https://jira.appcelerator.org/browse/TIMOB-25672