Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7_0_X][TIMOB-25674] Fix regex to allow folders beginning with a platform name #9736

Merged
merged 2 commits into from Jan 18, 2018
Merged

[7_0_X][TIMOB-25674] Fix regex to allow folders beginning with a platform name #9736

merged 2 commits into from Jan 18, 2018

Conversation

ewanharris
Copy link
Collaborator

7_0_X backport for #9735

JIRA: https://jira.appcelerator.org/browse/TIMOB-25674

This only occurs in the iOS build, Android uses a different method of filtering

@ewanharris ewanharris changed the title [TIMOB-25674] Fix regex to allow folders beginning with a platform name [7_0_X][TIMOB-25674] Fix regex to allow folders beginning with a platform name Jan 15, 2018
@hansemannn hansemannn added this to the 7.0.2 milestone Jan 17, 2018
@sgtcoolguy sgtcoolguy self-requested a review January 17, 2018 16:35
sgtcoolguy
sgtcoolguy approved these changes Jan 17, 2018
View reviewed changes
Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for QE to test

@build
Copy link
Contributor

build commented Jan 17, 2018

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@ewieberappc ewieberappc self-requested a review January 18, 2018 16:29
ewieberappc
ewieberappc approved these changes Jan 18, 2018
View reviewed changes
Copy link
Contributor

@ewieberappc ewieberappc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed. Folders beginning with a platform name are present in builds

@ewieberappc ewieberappc merged commit 67113d0 into tidev:7_0_X Jan 18, 2018
@ewanharris ewanharris deleted the TIMOB-25674_7_0_X branch August 31, 2021 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgtcoolguy sgtcoolguy sgtcoolguy approved these changes

@ewieberappc ewieberappc ewieberappc approved these changes

Assignees

@ewanharris ewanharris

Labels
bug in-qe-testing 🕵 ios
Projects
None yet
Milestone
7.0.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ewanharris @build @sgtcoolguy @ewieberappc @hansemannn