[TIMOB-25678] Android: Amend hasActivityTransitions() for transitions #9740

garymathews · 2018-01-16T22:01:51Z

Fix hasActivityTransitions() to allow transitions when a sharedElement has not been specified

TEST CASE

var win = Ti.UI.createWindow({
        backgroundColor: 'blue',
        layout: 'vertical'
    }),
    lbl = Ti.UI.createLabel({
        left: 5,
        text: 'TEST LABEL',
        transitionName: 'lbl'
    }),
    btn = Ti.UI.createButton({
        title: 'OPEN'
    });

btn.addEventListener('click', function () {
    var win2 = Ti.UI.createWindow({
            backgroundColor: 'red',
            layout: 'vertical',
            activityEnterTransition: Titanium.UI.Android.TRANSITION_SLIDE_RIGHT
        }),
        lbl2 = Ti.UI.createLabel({
            right: 5,
            text: 'TEST LABEL',
            transitionName: 'lbl'
        }),
        btn2 = Ti.UI.createButton({
            title: 'CLOSE'
        });

    btn2.addEventListener('click', function () {
        win2.close();
    });

    win2.add([lbl2, btn2]);
    // win2.addSharedElement(lbl, 'lbl'); // this should not need uncommenting to see a Window transition

    win2.open();
});

win.add([lbl, btn]);
win.open();

JIRA Ticket

jquick-axway

CR: Pass

hansemannn · 2018-06-28T06:31:57Z

@garymathews Jenkins still crashes during unit-tests. For this build, it looks like viewSizeAndRectPx crashes the app:


[INFO] : �� � !TEST_START: viewSizeAndRectPx

[ERROR] : �� �Surface: getSlotFromBufferLocked: unknown buffer: 0xa09e10e0

[ERROR] : �� �Surface: getSlotFromBufferLocked: unknown buffer: 0xa09e1680

[INFO] : �� � art: Starting a blocking GC HeapTrim

Sending interrupt signal to process

-- End application log -------------------------------------------------------

lokeshchdhry · 2018-09-28T19:44:37Z

@garymathews, the window transition does not work on Android 4.1 with or without using win2.addSharedElement(lbl, 'lbl'); & its not just with this fix but with older SDK as well.

sgtcoolguy · 2018-10-03T13:32:38Z

This is consistently crashing on the CI builds:


[INFO] : �� � !TEST_START: PlainPicker change event
[INFO] : �� � Choreographer: Skipped 37 frames!  The application may be doing too much work on its main thread.
[ERROR] : �� �Surface: getSlotFromBufferLocked: unknown buffer: 0x9fda1980
[ERROR] : �� �Surface: getSlotFromBufferLocked: unknown buffer: 0x9fd9f720
[ERROR] : �� �TiExceptionHandler: (main) [3706,163285]
[ERROR] : �� �TiExceptionHandler:     android.app.EnterTransitionCoordinator.allowOverlappingTransitions(EnterTransitionCoordinator.java:597)
[ERROR] : �� �TiExceptionHandler:     android.app.EnterTransitionCoordinator.sendSharedElementDestination(EnterTransitionCoordinator.java:177)
[ERROR] : �� �TiExceptionHandler:     android.app.EnterTransitionCoordinator.viewsReady(EnterTransitionCoordinator.java:120)
[ERROR] : �� �TiExceptionHandler:     android.app.EnterTransitionCoordinator$2.onPreDraw(EnterTransitionCoordinator.java:145)
[ERROR] : �� �TiExceptionHandler:     android.view.ViewTreeObserver.dispatchOnPreDraw(ViewTreeObserver.java:944)
[ERROR] : �� �TiExceptionHandler:     android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:2055)
[ERROR] : �� �TiExceptionHandler:     android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1107)
[ERROR] : �� �TiExceptionHandler:     android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:6013)
[ERROR] : �� �TiExceptionHandler:     android.view.Choreographer$CallbackRecord.run(Choreographer.java:858)
[ERROR] : �� �TiExceptionHandler:     android.view.Choreographer.doCallbacks(Choreographer.java:670)
[ERROR] : �� �TiExceptionHandler:     android.view.Choreographer.doFrame(Choreographer.java:606)
[ERROR] : �� �TiExceptionHandler:     android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:844)
[ERROR] : �� �TiExceptionHandler:     android.os.Handler.handleCallback(Handler.java:739)
[ERROR] : �� �TiExceptionHandler:     android.os.Handler.dispatchMessage(Handler.java:95)
[ERROR] : �� �TiExceptionHandler:     android.os.Looper.loop(Looper.java:148)
[ERROR] : �� �TiExceptionHandler:     android.app.ActivityThread.main(ActivityThread.java:5417)
[ERROR] : �� �TiExceptionHandler:     java.lang.reflect.Method.invoke(Native Method)
[ERROR] : �� �TiExceptionHandler:     com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
[ERROR] : �� �TiExceptionHandler:     com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)

longton95 · 2018-10-16T14:57:49Z

@garymathews I am only seeing the transition if win2.addSharedElement(lbl, 'lbl'); is uncommented

garymathews · 2018-10-16T17:48:46Z

@longton95 Forgot one of my changes; try now?

garymathews · 2018-10-17T18:31:25Z

@longton95 I realized that my comment in the test case was unclear, you need the addSharedElement to see the label transition. But you should not need the addSharedElement to see the Window transition.

lokeshchdhry · 2018-10-19T21:42:06Z

@garymathews , When I run on Android 4.1 I see:

[ERROR] :  [Android SDK built for x86] TiExceptionHandler: (main) [155,155] ti:/window.js:76
[ERROR] :  [Android SDK built for x86] TiExceptionHandler: 		_open.call(this, options);
[ERROR] :  [Android SDK built for x86] TiExceptionHandler:         ^
[ERROR] :  [Android SDK built for x86] TiExceptionHandler: Error: android.app.ActivityOptions.makeBasic
[ERROR] :  [Android SDK built for x86] TiExceptionHandler:     at Window.open (ti:/window.js:76:9)
[ERROR] :  [Android SDK built for x86] TiExceptionHandler:     at /app.js:40:5
[ERROR] :  [Android SDK built for x86] TiExceptionHandler:     at Module._runScript (ti:/module.js:613:9)
[ERROR] :  [Android SDK built for x86] TiExceptionHandler:     at Module.load (ti:/module.js:105:7)
[ERROR] :  [Android SDK built for x86] TiExceptionHandler:     at Module.loadJavascriptText (ti:/module.js:457:9)
[ERROR] :  [Android SDK built for x86] TiExceptionHandler:     at Module.loadAsFile (ti:/module.js:512:15)
[ERROR] :  [Android SDK built for x86] TiExceptionHandler:     at Module.loadAsFileOrDirectory (ti:/module.js:429:20)
[ERROR] :  [Android SDK built for x86] TiExceptionHandler:     at Module.require (ti:/module.js:256:17)
[ERROR] :  [Android SDK built for x86] TiExceptionHandler:     at require (ti:/module.js:570:15)
[ERROR] :  [Android SDK built for x86] TiExceptionHandler:     at /ti.main.js:27:3
[ERROR] :  [Android SDK built for x86] TiExceptionHandler:
[ERROR] :  [Android SDK built for x86] TiExceptionHandler:     org.appcelerator.titanium.proxy.TiWindowProxy.createActivityOptionsBundle(TiWindowProxy.java:516)
[ERROR] :  [Android SDK built for x86] TiExceptionHandler:     ti.modules.titanium.ui.WindowProxy.handleOpen(WindowProxy.java:165)
[ERROR] :  [Android SDK built for x86] TiExceptionHandler:     org.appcelerator.titanium.proxy.TiWindowProxy.open(TiWindowProxy.java:154)
[ERROR] :  [Android SDK built for x86] TiExceptionHandler:     ti.modules.titanium.ui.WindowProxy.open(WindowProxy.java:125)
[ERROR] :  [Android SDK built for x86] TiExceptionHandler:     org.appcelerator.kroll.runtime.v8.V8Runtime.nativeRunModule(Native Method)
[ERROR] :  [Android SDK built for x86] TiExceptionHandler:     org.appcelerator.kroll.runtime.v8.V8Runtime.doRunModule(V8Runtime.java:180)
[ERROR] :  [Android SDK built for x86] TiExceptionHandler:     org.appcelerator.kroll.KrollRuntime.runModule(KrollRuntime.java:247)
[ERROR] :  [Android SDK built for x86] TiExceptionHandler:     org.appcelerator.titanium.TiLaunchActivity.loadActivityScript(TiLaunchActivity.java:135)
[ERROR] :  [Android SDK built for x86] TiExceptionHandler:     org.appcelerator.titanium.TiLaunchActivity.windowCreated(TiLaunchActivity.java:190)
[ERROR] :  [Android SDK built for x86] TiExceptionHandler:     org.appcelerator.titanium.TiRootActivity.windowCreated(TiRootActivity.java:185)
[ERROR] :  [Android SDK built for x86] V8Exception: Exception occurred at ti:/window.js:76: Uncaught Error: android.app.ActivityOptions.makeBasic

Also, I see the window & label transition with win2.addSharedElement(lbl, 'lbl'); uncommented (i.e present). But, I don't see the window transition with it commented (i.e not present).

garymathews · 2018-10-19T21:53:04Z

@lokeshchdhry Updated PR

lokeshchdhry · 2018-10-22T23:04:50Z

@garymathews , Without win2.addSharedElement(lbl, 'lbl');. I still don't see the window transition on all android versions. But with win2.addSharedElement(lbl, 'lbl'); I see both window & label transition.

lokeshchdhry · 2018-10-23T18:03:54Z

FR Passed.

Transitions works as expected when sharedElement has not been specified.

FYI : Transitions are not supported on Android 4.1

Studio Ver: 5.1.2.201810080801
SDK Ver: 7.5.0 local build
OS Ver: 10.14
Xcode Ver: Xcode 10.0
Appc NPM: 4.2.14-2
Appc CLI: 7.0.7-master.9
Daemon Ver: 1.1.3
Ti CLI Ver: 5.1.1
Alloy Ver: 1.13.3
Node Ver: 8.9.1
NPM Ver: 5.5.1
Java Ver: 10.0.2
Devices: ⇨ google Nexus 5 (Android 6.0.1)
⇨ google Pixel (Android 9)
Emulator: ⇨ Android 4.1.2

build · 2018-10-24T22:54:34Z

	Messages
📖	💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

…nsitions (#9740)" This reverts commit a36557c.

…nsitions" (#10404) * Revert "[TIMOB-26491] Update ti.cloudpush to 3.2.0 (#10403)" This reverts commit c77b295. * Revert "[TIMOB-26484] Android: Added "sound" support to NotificationChannel (#10400)" This reverts commit 24ece5b. * Revert "[TIMOB-25678] Android: Amend hasActivityTransitions() for transitions (#9740)" This reverts commit a36557c.

garymathews added android bug labels Jan 16, 2018

build added android needs tests 🚨 labels Jan 16, 2018

garymathews added no tests and removed needs tests 🚨 labels Jan 16, 2018

jquick-axway approved these changes Jan 16, 2018

View reviewed changes

garymathews force-pushed the TIMOB-25678 branch from 00488b6 to 410e9a0 Compare January 17, 2018 21:42

sgtcoolguy added this to the 7.4.0 milestone Jun 26, 2018

sgtcoolguy added the in-qe-testing 🕵 label Jun 26, 2018

tidev deleted a comment from build Jun 27, 2018

hansemannn removed the in-qe-testing 🕵 label Jun 30, 2018

hansemannn modified the milestones: 7.4.0, 7.5.0 Aug 24, 2018

garymathews force-pushed the TIMOB-25678 branch from f850e41 to c385b81 Compare October 16, 2018 00:40

garymathews force-pushed the TIMOB-25678 branch from b833847 to 33e4ff4 Compare October 16, 2018 17:47

garymathews force-pushed the TIMOB-25678 branch from 4ffa611 to 0ce1ddd Compare October 17, 2018 17:43

[TIMOB-25678] Amend hasActivityTransitions() for transitions

4bf26aa

garymathews force-pushed the TIMOB-25678 branch from 0ce1ddd to 4bf26aa Compare October 17, 2018 18:29

[TIMOB-25678] Always create activity bundle

a7e7f2f

garymathews force-pushed the TIMOB-25678 branch from cc3a7b1 to a7e7f2f Compare October 18, 2018 22:15

garymathews force-pushed the TIMOB-25678 branch from d222025 to 4e7ec5f Compare October 19, 2018 21:52

[TIMOB-25678] Use ActivityOptionsCompat

fe43726

garymathews force-pushed the TIMOB-25678 branch from 363b272 to fe43726 Compare October 22, 2018 20:56

garymathews force-pushed the TIMOB-25678 branch from f48267f to ed8557f Compare October 22, 2018 23:57

garymathews force-pushed the TIMOB-25678 branch from 2219ca2 to 47614be Compare October 24, 2018 23:24

[TIMOB-25678] Fix compatibility

5a552c7

garymathews force-pushed the TIMOB-25678 branch from 5660789 to 5a552c7 Compare October 25, 2018 20:44

Merge branch 'master' into TIMOB-25678

dcb2438

lokeshchdhry merged commit a36557c into tidev:master Oct 25, 2018

garymathews added a commit that referenced this pull request Oct 26, 2018

Revert "[TIMOB-25678] Android: Amend hasActivityTransitions() for tra…

12037ed

…nsitions (#9740)" This reverts commit a36557c.

garymathews mentioned this pull request Oct 26, 2018

Revert "[TIMOB-25678] Android: Amend hasActivityTransitions() for transitions" #10404

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TIMOB-25678] Android: Amend hasActivityTransitions() for transitions #9740

[TIMOB-25678] Android: Amend hasActivityTransitions() for transitions #9740

garymathews commented Jan 16, 2018 •

edited

jquick-axway left a comment

hansemannn commented Jun 28, 2018

lokeshchdhry commented Sep 28, 2018

sgtcoolguy commented Oct 3, 2018

longton95 commented Oct 16, 2018

garymathews commented Oct 16, 2018

garymathews commented Oct 17, 2018 •

edited

lokeshchdhry commented Oct 19, 2018 •

edited

garymathews commented Oct 19, 2018

lokeshchdhry commented Oct 22, 2018 •

edited

lokeshchdhry commented Oct 23, 2018

build commented Oct 24, 2018 •

edited

[TIMOB-25678] Android: Amend hasActivityTransitions() for transitions #9740

[TIMOB-25678] Android: Amend hasActivityTransitions() for transitions #9740

Conversation

garymathews commented Jan 16, 2018 • edited

TEST CASE

jquick-axway left a comment

Choose a reason for hiding this comment

hansemannn commented Jun 28, 2018

lokeshchdhry commented Sep 28, 2018

sgtcoolguy commented Oct 3, 2018

longton95 commented Oct 16, 2018

garymathews commented Oct 16, 2018

garymathews commented Oct 17, 2018 • edited

lokeshchdhry commented Oct 19, 2018 • edited

garymathews commented Oct 19, 2018

lokeshchdhry commented Oct 22, 2018 • edited

lokeshchdhry commented Oct 23, 2018

build commented Oct 24, 2018 • edited

garymathews commented Jan 16, 2018 •

edited

garymathews commented Oct 17, 2018 •

edited

lokeshchdhry commented Oct 19, 2018 •

edited

lokeshchdhry commented Oct 22, 2018 •

edited

build commented Oct 24, 2018 •

edited