Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25680] (7_0_X) iOS: Workaround the iOS 11.2+ document-viewer issue #9742

Merged
merged 7 commits into from Jan 23, 2018
Merged

[TIMOB-25680] (7_0_X) iOS: Workaround the iOS 11.2+ document-viewer issue #9742

merged 7 commits into from Jan 23, 2018

Conversation

hansemannn
Copy link
Collaborator

@hansemannn hansemannn commented Jan 17, 2018 •
edited

JIRA: https://jira.appcelerator.org/browse/TIMOB-25680

no tests because it's a change unit-tests cannot measure.

@hansemannn hansemannn added this to the 7.0.2 milestone Jan 17, 2018
@hansemannn hansemannn self-assigned this Jan 17, 2018
@build
Copy link
Contributor

build commented Jan 17, 2018 •
edited

Fails
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.
Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

vijaysingh-axway
vijaysingh-axway approved these changes Jan 19, 2018
View reviewed changes
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR and FT passed.

@ewieberappc
Copy link
Contributor

FR Passed. Workaround is working as designed. Document viewer is able to display PDF files in iOS 11.X

@eric34 eric34 merged commit 9aea28b into tidev:7_0_X Jan 23, 2018
@hansemannn hansemannn deleted the TIMOB-25680-7_0_X branch January 23, 2018 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vijaysingh-axway vijaysingh-axway vijaysingh-axway approved these changes

Assignees

@hansemannn hansemannn

Labels
bug docs in-qe-testing 🕵 ios no tests
Projects
None yet
Milestone
7.0.2
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@hansemannn @build @ewieberappc @vijaysingh-axway @eric34 @garymathews