Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7_0_X][TIMOB-25661] Android: Fix broken animation behaviour on Android 7.0+ #9752

Merged
merged 6 commits into from Jan 24, 2018
Merged

[7_0_X][TIMOB-25661] Android: Fix broken animation behaviour on Android 7.0+ #9752

merged 6 commits into from Jan 24, 2018

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews added this to the 7.0.2 milestone Jan 18, 2018
@build build added the android label Jan 18, 2018
@build
Copy link
Contributor

build commented Jan 18, 2018 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@lokeshchdhry
Copy link
Contributor

FR Passed.

Animation behavior seems to work as expected.

Studio Ver: 5.0.0.201712081732
SDK Ver: 7.0.1 local build
OS Ver: 10.13.2
Xcode Ver: Xcode 9.2
Appc NPM: 4.2.11
Appc CLI: 7.0.1
Daemon Ver: 1.0.1
Ti CLI Ver: 5.0.14
Alloy Ver: 1.10.10
Node Ver: 8.9.1
NPM Ver: 5.5.1
Java Ver: 1.8.0_101
Devices: ⇨ google Pixel XL --- Android 8.0.0
⇨ google Nexus 5 --- Android 6.0.1
google pixel --- Android 7.1.1
Emulator: Android 7.0.0

@build build added the android label Jan 19, 2018
ypbnv
ypbnv approved these changes Jan 19, 2018
View reviewed changes
Copy link
Contributor

@ypbnv ypbnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@lokeshchdhry
Copy link
Contributor

@garymathews , I see there is a test failure here can you please fix it.

@build build added the android label Jan 23, 2018
@lokeshchdhry lokeshchdhry merged commit 4c70b76 into tidev:7_0_X Jan 24, 2018
@garymathews garymathews mentioned this pull request Feb 1, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ypbnv ypbnv ypbnv approved these changes

Assignees
No one assigned
Labels
android bug no tests
Projects
None yet
Milestone
7.0.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@garymathews @build @lokeshchdhry @ypbnv