[TIMOB-23888] iOS: Use asynchronous openURL API on iOS 10+ #9759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vijaysingh-axway
suggested changes
Jan 29, 2018
iphone/Classes/PlatformModule.m
Outdated
| NSMutableDictionary *options = [NSMutableDictionary dictionary]; | ||
|
|
||
| if ([args count] > 0) { | ||
| if ([[args objectAtIndex:1] isKindOfClass:[NSDictionary class]]) { |
There was a problem hiding this comment.
In case of count = 1, [args objectAtIndex:1] will fail. Due to this first test case is failing.
| * UIApplicationOpenURLOptionsSourceApplicationKey | ||
| * UIApplicationOpenURLOptionsAnnotationKey | ||
| * UIApplicationOpenURLOptionsOpenInPlaceKey | ||
| * UIApplicationOpenURLOptionUniversalLinksOnly |
There was a problem hiding this comment.
We should give the detail about the values of these string-keys. e.g For UIApplicationOpenURLOptionUniversalLinksOnly value should be Bool or give an apple link here.
And normally we map apple keys with Titanium keys. Isn't it good to use titanium keys?
There was a problem hiding this comment.
The reason I've not made this a constant is because we cannot use constants as dictionary-keys, so the dev would need to declare a variable first and then use that one as a key. I'll add more infos about the constants though!
Generated by 🚫 dangerJS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-23888