Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-24266] iOS: Expose UIApplicationDelegate to modules / Hyperloop #9761

Merged
merged 6 commits into from Mar 21, 2018
Merged

[TIMOB-24266] iOS: Expose UIApplicationDelegate to modules / Hyperloop #9761

merged 6 commits into from Mar 21, 2018

Conversation

hansemannn
Copy link
Collaborator

@hansemannn hansemannn added this to the 7.1.0 milestone Jan 22, 2018
@build
Copy link
Contributor

build commented Jan 22, 2018 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@build build added the ios label Jan 23, 2018
@hansemannn
Copy link
Collaborator Author

@vijaysingh-axway @janvennemann Ping for the review.

@hansemannn hansemannn modified the milestones: 7.1.0, 7.2.0 Feb 16, 2018
vijaysingh-axway
vijaysingh-axway approved these changes Feb 22, 2018
View reviewed changes
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR and FT passed.

@build build added the ios label Feb 22, 2018
@hansemannn
Copy link
Collaborator Author

@janvennemann Your Review?

janvennemann
janvennemann approved these changes Mar 21, 2018
View reviewed changes
Copy link
Contributor

@janvennemann janvennemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@build build added the ios label Mar 21, 2018
@hansemannn hansemannn merged commit 62e42b5 into tidev:master Mar 21, 2018
build pushed a commit to garymathews/titanium_mobile that referenced this pull request Apr 23, 2018
@hansemannn @sgtcoolguy
[TIMOB-24266] Expose UIApplicationDelegate to modules / Hyperloop (ti…
ab66372 
…dev#9761)
@sgtcoolguy sgtcoolguy modified the milestones: 7.2.0, 7.3.0 May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janvennemann janvennemann janvennemann approved these changes

@vijaysingh-axway vijaysingh-axway vijaysingh-axway approved these changes

Assignees
No one assigned
Labels
improvement in-qe-testing 🕵 ios no tests
Projects
None yet
Milestone
7.3.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hansemannn @build @janvennemann @vijaysingh-axway @sgtcoolguy