New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-25201] : iOS tintColor doesn't work on imageView if dimensions (height, width) are provided #9762
Conversation
… (height, width) are provided
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great fix, approved!
Generated by 🚫 dangerJS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FR Passed: Was able to see the tint applied with the following test case:
Ti.UI.backgroundColor = 'orange';
var win = Ti.UI.createWindow();
var view = Ti.UI.createView({
backgroundColor: 'green',
height: 100,
layout: 'vertical'
});
var image = Ti.UI.createImageView({
image:'/ic_tv_white_48.png',
tintColor: 'red',
width: 40,
height: 40
});
var image2 = Ti.UI.createImageView({
image:'/ic_tv_white_48.png',
tintColor: 'blue'
});
view.add(image);
view.add(image2);
win.add(view);
win.open();
Test steps
- Created a build with the generated zip
- Created a titanium app
- Added the test case above
- Ran the program
- Was able to see the tint applied
- Checked other colours for tint to verify it was working as intended
Test Environment
APPC Studio: 5.0.0.201711280737
APPC CLI: 7.0.1
iphone 6 plus (10.2)
Operating System Name: Mac OS High Sierra
Operating System Version: 10.13
Node.js Version: 8.9.1
Xcode 9.2
@vijaysingh-axway Needs back porting to 7.1.0 |
https://jira.appcelerator.org/browse/TIMOB-25201