Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7_0_X][TIMOB-25540] Fix sizeOf() calculation to prevent IllegalStateException #9764

Merged
merged 5 commits into from Jan 25, 2018
Merged

[7_0_X][TIMOB-25540] Fix sizeOf() calculation to prevent IllegalStateException #9764

merged 5 commits into from Jan 25, 2018

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews added this to the 7.0.2 milestone Jan 23, 2018
@garymathews garymathews changed the title [TIMOB-25540] Fix sizeOf() calculation to prevent IllegalStateException [7_0_X][TIMOB-25540] Fix sizeOf() calculation to prevent IllegalStateException Jan 23, 2018
@build build added the android label Jan 23, 2018
@build
Copy link
Contributor

build commented Jan 23, 2018 •
edited

Fails
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.
Messages
📖

👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

jquick-axway
jquick-axway approved these changes Jan 23, 2018
View reviewed changes
Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@mukherjee2 mukherjee2 self-requested a review January 23, 2018 19:12
mukherjee2
mukherjee2 approved these changes Jan 23, 2018
View reviewed changes
Copy link
Contributor

@mukherjee2 mukherjee2 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node Version: 8.9.1
NPM Version: 5.5.1
Mac OS: 10.13.1
Appc CLI: 7.0.1
Appc CLI NPM: 4.2.11
Titanium SDK version: 7.0.2.v20180123092533
Appcelerator Studio vers 5.0.0
Android 8.1 Device

Validated fix with the above environment.

@eric34 eric34 merged commit c636b76 into tidev:7_0_X Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mukherjee2 mukherjee2 mukherjee2 approved these changes

@jquick-axway jquick-axway jquick-axway approved these changes

Assignees
No one assigned
Labels
android bug in-qe-testing 🕵 needs tests 🚨
Projects
None yet
Milestone
7.0.2
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@garymathews @build @mukherjee2 @jquick-axway @eric34 @sgtcoolguy