Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-15091] iOS: Allow using module views in Ti.UI.ListView templates #9767

Closed
wants to merge 8 commits into from
Closed

[TIMOB-15091] iOS: Allow using module views in Ti.UI.ListView templates #9767

wants to merge 8 commits into from

Conversation

hansemannn
Copy link
Collaborator

@hansemannn hansemannn added this to the 7.1.0 milestone Jan 24, 2018
@build
Copy link
Contributor

build commented Jan 24, 2018 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

vijaysingh-axway
vijaysingh-axway approved these changes Feb 1, 2018
View reviewed changes
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR and FT passed.

@hansemannn hansemannn modified the milestones: 7.1.0, 7.2.0 Feb 15, 2018
@hansemannn
Copy link
Collaborator Author

Moving out of 7.1.0 due to missing Android parity.

@hansemannn hansemannn mentioned this pull request Apr 26, 2018
Closed
@sgtcoolguy sgtcoolguy modified the milestones: 7.2.0, 7.3.0 May 16, 2018
@sgtcoolguy sgtcoolguy modified the milestones: 7.3.0, 7.4.0 May 23, 2018
@sgtcoolguy
Copy link
Contributor

Pushing to 7.4.0 as we should have an Android equivalent merged at the same time.

@sgtcoolguy sgtcoolguy added the hold for parity ✋ This PR should not be merged until an equivalent PR is ready for the other platform(s) label Jun 19, 2018
@sgtcoolguy
Copy link
Contributor

@garymathews @jquick-axway I've opened https://jira.appcelerator.org/browse/TIMOB-26138 to address the Android side of this. We shouldn't merge this PR until we have the Android equivalent...

@build
Copy link
Contributor

build commented Jun 19, 2018 •
edited

Messages
📖

🎉 Another contribution from our awesome community member, hansemannn! Thanks again for helping us make Titanium SDK better. 👍

Generated by 🚫 dangerJS

@sgtcoolguy sgtcoolguy mentioned this pull request Jun 25, 2018
Merged
@hansemannn
Copy link
Collaborator Author

@sgtcoolguy Let's close this PR and the related ticket. Modules can be used with #10131 by simply returning the view via getView() in a module, like:

var map = require('ti.map');
var mapView = map.createView({ /** ... **/ });

exports.getView = () => {
  return mapView;
};

so introducing another module property is nonsense. Or am I missing something?

@hansemannn hansemannn modified the milestones: 7.4.0, 7.5.0 Aug 24, 2018
@vijaysingh-axway
Copy link
Contributor

@sgtcoolguy Should we close this PR as suggested by Hans in above comment?

@lokeshchdhry
Copy link
Contributor

@sgtcoolguy , @vijaysingh-axway , What are we doing with this PR ?

@sgtcoolguy sgtcoolguy removed this from the 7.5.0 milestone Oct 30, 2018
@janvennemann janvennemann modified the milestone: 8.0.1 Jan 16, 2019
@hansemannn hansemannn closed this May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vijaysingh-axway vijaysingh-axway vijaysingh-axway approved these changes

Assignees
No one assigned
Labels
community 🔥 docs feature hold for parity ✋ This PR should not be merged until an equivalent PR is ready for the other platform(s) ios merge conflicts 🚨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@hansemannn @build @sgtcoolguy @vijaysingh-axway @lokeshchdhry @janvennemann