[TIMOB-10368] iOS: Expose "color" and "hintTextColor" to Ti.UI.SearchBar #9772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jquick-axway
suggested changes
Jan 27, 2018
apidoc/Titanium/UI/SearchBar.yml
Outdated
| description: | | ||
| For information about color values, see the "Colors" section of <Titanium.UI>. | ||
| type: String | ||
| platforms: [iphone, ipad] |
There was a problem hiding this comment.
Android already supports this, just wasn't documented. Would you mind adding "android" to the supported platform list please?
apidoc/Titanium/UI/SearchBar.yml
Outdated
| - name: hintText | ||
| summary: Text to show when the search bar field is not focused. | ||
| type: String | ||
| default: On iOS, "Search"; on Android, no hint text. | ||
|
|
||
| - name: hintTextColor | ||
| summary: Hint text color to display when the field is empty. | ||
| platforms: [iphone, ipad] |
There was a problem hiding this comment.
Android already supports this property too.
|
|
||
| // TODO: Expose on Android / Windows as well | ||
| // We have in in Ti.UI.Android.SearchView for Android, but need more parity here | ||
| it.ios('.hintTextColor', function () { |
There was a problem hiding this comment.
Android can run this unit test too.
Change to it.windowsMissing?
| }); | ||
|
|
||
| // TODO: Expose on Android / Windows as well | ||
| it.ios('.color', function () { |
There was a problem hiding this comment.
Android can run this unit test.
Change to it.windowsMissing?
|
@jquick-axway Can you update your review? |
Generated by 🚫 dangerJS |
|
FR Passed. Tested with 7_1_X branch PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-10368