Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25735] Android: Use TiBaseActivity.isDestroyed() #9781

Merged
merged 1 commit into from Jan 30, 2018
Merged

[TIMOB-25735] Android: Use TiBaseActivity.isDestroyed() #9781

merged 1 commit into from Jan 30, 2018

Conversation

garymathews
Copy link
Contributor

  • Use TiBaseActivity.isDestroyed() for Android 4.1 compatibility

JIRA Ticket

@garymathews garymathews added this to the 7.1.0 milestone Jan 30, 2018
@garymathews garymathews mentioned this pull request Jan 30, 2018
Merged
@garymathews
Copy link
Contributor Author

no tests, tests are already included here

@build build added the android label Jan 30, 2018
@build build added the android label Jan 30, 2018
@build
Copy link
Contributor

build commented Jan 30, 2018

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

jquick-axway
jquick-axway approved these changes Jan 30, 2018
View reviewed changes
Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@lokeshchdhry
Copy link
Contributor

FR Passed.

App does not crash on Android 4.1.

Verified the issue which caused this regression with this fix & it seems to work as well.

Studio Ver: 5.0.0.201712081732
SDK Ver: 7.1.0 local build
OS Ver: 10.13.2
Xcode Ver: Xcode 9.2
Appc NPM: 4.2.11
Appc CLI: 7.0.2-master.6
Daemon Ver: 1.0.1
Ti CLI Ver: 5.0.14
Alloy Ver: 1.10.12
Node Ver: 8.9.1
NPM Ver: 5.5.1
Java Ver: 1.8.0_101
Devices: ⇨ google Pixel --- Android 7.1.1
⇨ google Nexus 5 --- Android 6.0.1
Emulator: Android 4.1

@lokeshchdhry lokeshchdhry merged commit a3877f1 into tidev:master Jan 30, 2018
@garymathews garymathews mentioned this pull request Apr 23, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jquick-axway jquick-axway jquick-axway approved these changes

Assignees
No one assigned
Labels
android bug in-qe-testing 🕵 no tests
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@garymathews @build @lokeshchdhry @jquick-axway