Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-25734] Android: Fix click and touch events for TextField and TextArea #9785

Merged
merged 5 commits into from Feb 6, 2018

Conversation

garymathews
Copy link
Contributor

  • Fix click and touch events for TextField and TextArea
TEST CASE
var win = Ti.UI.createWindow({ backgroundColor : 'gray' }),
    tf = Ti.UI.createTextField({
        color : 'black',
        hintText : 'TEXT',
    });

tf.addEventListener('click', function() {
    Ti.API.info('CLICK');
});
tf.addEventListener('dblclick', function() {
    Ti.API.info('CLICK');
});
tf.addEventListener('singletap', function() {
    Ti.API.info('TAP');
});

win.add(tf);
win.open();

JIRA Ticket

@build
Copy link
Contributor

build commented Feb 1, 2018

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@lokeshchdhry
Copy link
Contributor

lokeshchdhry commented Feb 1, 2018

FR Passed.

click, focus,dblclick,singletap events works as expected for textfeild & textarea.

Studio Ver: 5.0.0.201712081732
SDK Ver: 7.1.0 local build
OS Ver: 10.13.2
Xcode Ver: Xcode 9.2
Appc NPM: 4.2.11
Appc CLI: 7.0.2-master.7
Daemon Ver: 1.0.1
Ti CLI Ver: 5.0.14
Alloy Ver: 1.10.12
Node Ver: 8.9.1
NPM Ver: 5.5.1
Java Ver: 1.8.0_101
Devices: ⇨ google Nexus 5 --- Android 6.0.1
⇨ google Pixel --- Android 7.1.1

@lokeshchdhry
Copy link
Contributor

@garymathews ,can you please add tests.

@garymathews
Copy link
Contributor Author

No test, this requires user input

@build build added the android label Feb 6, 2018
@lokeshchdhry lokeshchdhry merged commit efd83ca into tidev:master Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants