[TIMOB-25675] : iOS11 Button in navigation-bar remains in pressed state when opening new window #9799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te when opening new window
hansemannn
reviewed
Feb 5, 2018
| @@ -181,6 +181,11 @@ - (void)windowClosing:(TiWindowProxy *)window animated:(BOOL)animated | |||
|
|
|||
| - (void)navigationController:(UINavigationController *)navigationController willShowViewController:(UIViewController *)viewController animated:(BOOL)animated | |||
| { | |||
| if ([TiUtils isIOSVersionOrGreater:@"11.2"]) { | |||
| navigationController.navigationBar.tintAdjustmentMode = UIViewTintAdjustmentModeNormal; | |||
| navigationController.navigationBar.tintAdjustmentMode = UIViewTintAdjustmentModeAutomatic; | |||
There was a problem hiding this comment.
Both? That doesn‘t seem righr.
There was a problem hiding this comment.
Yes. If you see the discussion at https://stackoverflow.com/questions/47754472/ios-uinavigationbar-button-remains-faded-after-segue-back, the same is suggested.
There was a problem hiding this comment.
Weird, but valid. Can you file a radar for this as well?
There was a problem hiding this comment.
Yes. I'll file bug to apple.
hansemannn
approved these changes
Feb 5, 2018
hansemannn
changed the title
|
FR Passed on 7_0_X branch |
vijaysingh-axway
changed the title
Generated by 🚫 dangerJS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-25675