[TIMOB-24349] iOS: Fix both AlertDialog and OptionDialog to fire events properly #9803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
|
FR Passed. All alert/click events were fired and heard correctly, including those in the background. Tested using the provided samples, modified versions to check additional variants, and the alert dialog suite. |
build
pushed a commit
to garymathews/titanium_mobile
that referenced
this pull request
Apr 23, 2018
…ts properly (tidev#9803) * [TIMOB-24349] Fix alert dialog event from not firing * [TIMOB-24349] Fix option dialog as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-24349
no testsbecause it's a UI related change.