Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloudpush 5.0.2 #9805

Merged
merged 1 commit into from Feb 6, 2018
Merged

Cloudpush 5.0.2 #9805

merged 1 commit into from Feb 6, 2018

Conversation

sgtcoolguy
Copy link
Contributor

JIRA: https://jira.appcelerator.org/browse/TIMOB-25617

Description:
Update pre-packaged cloudpush module to 5.0.2.

@sgtcoolguy sgtcoolguy added this to the 7.0.2 milestone Feb 6, 2018
@build
Copy link
Contributor

build commented Feb 6, 2018

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@ewanharris
Copy link
Collaborator

@sgtcoolguy Is this required to through the FR process or am I good to merge?

@sgtcoolguy
Copy link
Contributor Author

@ewanharris I think the only concern to keep in mind is whether it's ok to add another ticket into 7.0.2 (or whatever next version is) for QE to verify/restart smokes/whatever.

@mukherjee2 mukherjee2 self-requested a review February 6, 2018 21:43
mukherjee2
mukherjee2 approved these changes Feb 6, 2018
View reviewed changes
Copy link
Contributor

@mukherjee2 mukherjee2 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The module has already been tested and passed. This ticket updates the URL to point to module version from 5.0.1 to 5.0.2. I'll verify the SDK after the merge that the links are updated correctly.

@mukherjee2 mukherjee2 merged commit d4b8b03 into tidev:7_0_X Feb 6, 2018
@sgtcoolguy sgtcoolguy deleted the cloudpush-5.0.2-7_0_X branch February 7, 2018 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mukherjee2 mukherjee2 mukherjee2 approved these changes

@ewanharris ewanharris Awaiting requested review from ewanharris

Assignees
No one assigned
Labels
android bug
Projects
None yet
Milestone
7.0.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sgtcoolguy @build @ewanharris @mukherjee2