Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25757] Android: Improve java proxy validation #9808

Merged
merged 5 commits into from Feb 23, 2018
Merged

[TIMOB-25757] Android: Improve java proxy validation #9808

merged 5 commits into from Feb 23, 2018

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Feb 6, 2018 •
edited

  • Improve validation of the javaProxy object getters and setters
TEST CASE
Ti.API.bubbleParent; // this should not crash!!

JIRA Ticket

@garymathews garymathews added this to the 7.1.0 milestone Feb 6, 2018
@build
Copy link
Contributor

build commented Feb 6, 2018 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

sgtcoolguy
sgtcoolguy suggested changes Feb 8, 2018
View reviewed changes
Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please add a unit test. I assume your small code snippet there used to crash us and now doesn't?

We should add a test that just verifies we don't crash:

it.android('TIMOB-25757', function() {
  should.not.exist(Ti.API.bubbleParent);
});

@garymathews garymathews mentioned this pull request Feb 15, 2018
Merged
@hansemannn hansemannn modified the milestones: 7.1.0, 7.2.0 Feb 17, 2018
@garymathews garymathews force-pushed the TIMOB-25757 branch 2 times, most recently from 1fe167d to 85d2cad Compare February 21, 2018 21:32
@build build added the android label Feb 21, 2018
@lokeshchdhry
Copy link
Contributor

FR Passed.

No crash seen.

Studio Ver: 5.0.0.201712081732
SDK Ver: 7.2.0 local build
OS Ver: 10.13.2
Xcode Ver: Xcode 9.2
Appc NPM: 4.2.12
Appc CLI: 7.0.2
Daemon Ver: 1.0.1
Ti CLI Ver: 5.0.14
Alloy Ver: 1.11.0
Node Ver: 8.9.1
NPM Ver: 5.5.1
Java Ver: 1.8.0_101
Devices: ⇨ google Nexus 5 --- Android 6.0.1
⇨ google Nexus 6P --- Android 8.0.0

@lokeshchdhry lokeshchdhry merged commit 80b3b72 into tidev:master Feb 23, 2018
@sgtcoolguy sgtcoolguy modified the milestones: 7.2.0, 7.3.0 May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgtcoolguy sgtcoolguy sgtcoolguy requested changes

Assignees
No one assigned
Labels
android bug
Projects
None yet
Milestone
7.3.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@garymathews @build @lokeshchdhry @sgtcoolguy @hansemannn