Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-25767] Android: Do not update properties after a transformation #9816

Merged
merged 3 commits into from Feb 13, 2018

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Feb 9, 2018

  • Do not update the proxy properties after an animation
TEST CASE
var win = Ti.UI.createWindow();
    view = Ti.UI.createView({
        backgroundColor:'red',
        width: 100, height: 100,
        left: 100,  top: 100
    });

win.addEventListener('open', function () {
    var animation = Ti.UI.createAnimation({
        top: 150,
        duration: 1000
    });

    animation.addEventListener('complete', function () {
        // make sure to give it time to layout
        setTimeout(function () {
            console.log(`X: ${view.rect.x} == 150, TOP: ${view.top} == 100`);
        }, 500);
    });

    view.animate(animation);

});
win.add(view);
win.open();

JIRA Ticket

@garymathews garymathews added this to the 7.1.0 milestone Feb 9, 2018
@build
Copy link
Contributor

build commented Feb 9, 2018

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

Copy link
Contributor

@ypbnv ypbnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lokeshchdhry
Copy link
Contributor

FR Passed.

View properties do not change after transformation.

Studio Ver: 5.0.0.201712081732
SDK Ver: 7.1.0 local build
OS Ver: 10.13.2
Xcode Ver: Xcode 9.2
Appc NPM: 4.2.12
Appc CLI: 7.0.2
Daemon Ver: 1.0.1
Ti CLI Ver: 5.0.14
Alloy Ver: 1.11.0
Node Ver: 8.9.1
NPM Ver: 5.5.1
Java Ver: 1.8.0_101
Devices: ⇨ google Nexus 5 --- Android 6.0.1
⇨ google Nexus 6P --- Android 8.0.0

@lokeshchdhry lokeshchdhry merged commit 1150f82 into tidev:master Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants