[TIMOB-25775] iOS: Fix gradient getters #9819
Conversation
Generated by 🚫 dangerJS |
|
@sgtcoolguy We now lint the unit-tests as well? Thats cool. But do we have a CLI command to fix it as well? |
|
Question: |
|
@jquick-axway You mean the getters? There are supposed to work already, but the PR is still work in progress to investigate that. |
hansemannn
force-pushed
the
TIMOB-25775
branch
from
4a11f4c
to
4972ca2
Compare
hansemannn
force-pushed
the
TIMOB-25775
branch
from
b5e7a4d
to
6163c06
Compare
|
@jquick-axway Updated the tests and cleaned up the commit mess. Your decision if 7.1.0 or not :-). |
| y: 50 | ||
| }, | ||
| colors: [ 'red', 'blue' ], | ||
| startRadius: '90%', |
There was a problem hiding this comment.
Do we officially support percentage based radius settings? We currently document it as "Number" and not "Number/String".
http://docs.appcelerator.com/platform/latest/#!/api/Gradient-property-startRadius
I didn't implement support for this on Android because I assumed we didn't support this on iOS. It would be nice to have though, but the question is, what's it relative to? The width? The height? The shortest dimension? The longest dimension?
There was a problem hiding this comment.
We do support it because iOS handles all units in a central class (TiDimension). So we could support it on other platforms as well, but later.
There was a problem hiding this comment.
Okay, from looking at our iOS code here...
https://github.com/hansemannn/titanium_mobile/blob/8261c1c17d11628c9fe4b0a9452905e378fb254b/iphone/Classes/TiGradient.m#L244
A percentage based radius is relative to the distance from the center of the view to one of its corners (ie: hypotenuse divided by 2). Good to know.
I'm trying to provide an option for devs to draw a circle ring without having to use our "borderRadius" feature. So, we might want to make what the percentage based radius is relative to settable in the future so that the circle won't get clipped.
iphone/Classes/TiGradient.m
Outdated
|
|
||
| - (NSNumber *)startRadius | ||
| { | ||
| return [self valueForUndefinedKey:@"startRadius"]; |
There was a problem hiding this comment.
We don't document percentage based radius settings, but this will return it as a number between 0-100, right? I think it should return the original percentage string.
If we don't officially support percentage based radius, then I'm okay for making this a task for later.
There was a problem hiding this comment.
See comment above. But you are right, I need to change the return type to id.
There was a problem hiding this comment.
FR Passed: Able to receive a log of the gradient properties.
Test steps
- Created a build with the generated zip
- Created a titanium app
- Added the test case from https://jira.appcelerator.org/browse/TIMOB-25775
- Ran the program
- Was able to see the console log output gradient properties
[INFO] : red, blue
Test Environment
APPC Studio: 5.0.0.201712081732
APPC CLI: 7.0.3
iphone 6 plus (10.2)
Operating System Name: Mac OS High Sierra
Operating System Version: 10.13
Node.js Version: 8.9.1
Xcode 9.2
|
@jquick-axway @ssjsamir I've fixed the unit-test linting manually now. Still wondering if there is a better way. |
JIRA: https://jira.appcelerator.org/browse/TIMOB-25775
Eventually to be merged before #9815